[Oilpan]: Moving the FontSelector/FontCacheClient, CSSSegmentedFontFace, and FontFaceCache to the o…

Source/core/css/CSSFontSelector.cpp

 /*
  * Copyright (C) 2007, 2008, 2011 Apple Inc. All rights reserved.
  *           (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 209 matching lines @@
 {
     m_fontLoader.loadPendingFonts();
 }
 
 void CSSFontSelector::updateGenericFontFamilySettings(Document& document)
 {
     ASSERT(document.settings());
     m_genericFontFamilySettings = document.settings()->genericFontFamilySettings();
 }
 
+void CSSFontSelector::trace(Visitor* visitor)
+{
+    visitor->trace(m_fontFaceCache);

[haraken, 2014/04/07 14:10:12]

You need to trace m_fontLoader. I hope the plugin catches the error :)

[wibling-chromium, 2014/04/08 09:35:59]

It didn't. Thanks for catching this.
I just talked to Ian and the plugin will complain only if there is a member
field or superclass in the object that needs tracing which is not the case here.
The reason to not complain in this case was that it became close to impossible
since an object could have a trace method without it being called in e.g. the
non-oilpan build.

+    visitor->trace(m_clients);
 }
+
+}