Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: trunk/src/net/socket/tcp_socket_libevent.cc

Issue 227083002: Revert 261966 "make SetReceiveBufferSize and SetSendBufferSize r..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/net/socket/tcp_socket_libevent.h ('k') | trunk/src/net/socket/tcp_socket_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/socket/tcp_socket_libevent.cc
===================================================================
--- trunk/src/net/socket/tcp_socket_libevent.cc (revision 262001)
+++ trunk/src/net/socket/tcp_socket_libevent.cc (working copy)
@@ -501,18 +501,22 @@
return OK;
}
-int TCPSocketLibevent::SetReceiveBufferSize(int32 size) {
+bool TCPSocketLibevent::SetReceiveBufferSize(int32 size) {
DCHECK(CalledOnValidThread());
int rv = setsockopt(socket_, SOL_SOCKET, SO_RCVBUF,
- reinterpret_cast<const char*>(&size), sizeof(size));
- return (rv == 0) ? OK : MapSystemError(errno);
+ reinterpret_cast<const char*>(&size),
+ sizeof(size));
+ DCHECK(!rv) << "Could not set socket receive buffer size: " << errno;
+ return rv == 0;
}
-int TCPSocketLibevent::SetSendBufferSize(int32 size) {
+bool TCPSocketLibevent::SetSendBufferSize(int32 size) {
DCHECK(CalledOnValidThread());
int rv = setsockopt(socket_, SOL_SOCKET, SO_SNDBUF,
- reinterpret_cast<const char*>(&size), sizeof(size));
- return (rv == 0) ? OK : MapSystemError(errno);
+ reinterpret_cast<const char*>(&size),
+ sizeof(size));
+ DCHECK(!rv) << "Could not set socket send buffer size: " << errno;
+ return rv == 0;
}
bool TCPSocketLibevent::SetKeepAlive(bool enable, int delay) {
« no previous file with comments | « trunk/src/net/socket/tcp_socket_libevent.h ('k') | trunk/src/net/socket/tcp_socket_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698