tests/TestConfigParsing.cpp - Issue 2270823002: Some tests around surface creation and snapshotting with color space

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/TestConfigParsing.cpp

Issue 2270823002: Some tests around surface creation and snapshotting with color space (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/TestConfigParsing.cpp

diff --git a/tests/TestConfigParsing.cpp b/tests/TestConfigParsing.cpp

index 6f5c64aa2e93d9f6518e4960c0c9a9634919005f..1a7e5b94ab04f01492b8b8d806d32666f6e8c469 100644

--- a/tests/TestConfigParsing.cpp

+++ b/tests/TestConfigParsing.cpp

@@ -123,7 +123,11 @@ DEF_TEST(ParseConfigs_DefaultConfigs, reporter) {

REPORTER_ASSERT(reporter, !configs[19]->asConfigGpu());

REPORTER_ASSERT(reporter, !configs[24]->asConfigGpu());

REPORTER_ASSERT(reporter, configs[25]->asConfigGpu()->getColorType() == kRGBA_F16_SkColorType);

- REPORTER_ASSERT(reporter, configs[25]->asConfigGpu()->getColorSpace() == srgbColorSpace.get());

+ REPORTER_ASSERT(reporter, configs[25]->asConfigGpu()->getColorSpace());

+ REPORTER_ASSERT(reporter, configs[25]->asConfigGpu()->getColorSpace()->gammaNamed() ==

+ SkColorSpace::kLinear_GammaNamed);

+ REPORTER_ASSERT(reporter, configs[25]->asConfigGpu()->getColorSpace()->xyz() ==

+ srgbColorSpace->xyz());

REPORTER_ASSERT(reporter, configs[26]->asConfigGpu()->getColorType() == kN32_SkColorType);

REPORTER_ASSERT(reporter, configs[26]->asConfigGpu()->getColorSpace() == srgbColorSpace.get());

REPORTER_ASSERT(reporter, configs[33]->asConfigGpu()->getContextType() ==

« tests/SurfaceTest.cpp ('K') | « tests/SurfaceTest.cpp ('k') | tools/flags/SkCommonFlagsConfig.cpp » ('j') | no next file with comments »