Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2270743002:
Scopes: simplfy scope creation for with scopes. (Closed)
|
Created:
4 years, 4 months ago by marja Modified:
4 years, 4 months ago Reviewers:
Toon Verwaest CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionScopes: simplify scope creation.
With scopes: Don't call the ctor which wants a ScopeInfo if we
don't want to pass it, instead call a ctor which doesn't need it.
In addition, remove inner_scope from ctors and adjust it
explicitly afterwards. It's confusing that some ctors get passed
inner scopes and some outer scopes.
BUG=v8:5209
Committed: https://crrev.com/7eaeb5aea51a8c1858f39da4ad6539c01711b871
Cr-Commit-Position: refs/heads/master@{#38859}
Patch Set 1 #Patch Set 2 : fixing #Patch Set 3 : rebased #
Total comments: 1
Patch Set 4 : removed inner scopes from ctors #Patch Set 5 : rebased #Patch Set 6 : leaner version #Messages
Total messages: 27 (22 generated)
The CQ bit was checked by marja@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)
The CQ bit was checked by marja@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/7459)
The CQ bit was checked by marja@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
marja@chromium.org changed reviewers: + verwaest@chromium.org
lgtm https://codereview.chromium.org/2270743002/diff/40001/src/ast/scopes.cc File src/ast/scopes.cc (right): https://codereview.chromium.org/2270743002/diff/40001/src/ast/scopes.cc#newco... src/ast/scopes.cc:272: with_scope->AddInnerScope(current_scope); Perhaps we should just pull this out of the other constructor and put it at the end of the while body? I never liked that the Scope* argument to Scope can either be inner or outer scope, depending on ScopeInfo being passed in ...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Scopes: simplfy scope creation for with scopes. Don't call the ctor which wants a ScopeInfo if we don't want to pass it, instead call a ctor which doesn't need it. BUG=v8:5209 ========== to ========== Scopes: simplify scope creation. With scopes: Don't call the ctor which wants a ScopeInfo if we don't want to pass it, instead call a ctor which doesn't need it. In addition, remove inner_scope from ctors and adjust it explicitly afterwards. It's confusing that some ctors get passed inner scopes and some outer scopes. BUG=v8:5209 ==========
The CQ bit was checked by marja@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/11491) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
The CQ bit was checked by marja@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from verwaest@chromium.org Link to the patchset: https://codereview.chromium.org/2270743002/#ps100001 (title: "leaner version")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Scopes: simplify scope creation. With scopes: Don't call the ctor which wants a ScopeInfo if we don't want to pass it, instead call a ctor which doesn't need it. In addition, remove inner_scope from ctors and adjust it explicitly afterwards. It's confusing that some ctors get passed inner scopes and some outer scopes. BUG=v8:5209 ========== to ========== Scopes: simplify scope creation. With scopes: Don't call the ctor which wants a ScopeInfo if we don't want to pass it, instead call a ctor which doesn't need it. In addition, remove inner_scope from ctors and adjust it explicitly afterwards. It's confusing that some ctors get passed inner scopes and some outer scopes. BUG=v8:5209 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Scopes: simplify scope creation. With scopes: Don't call the ctor which wants a ScopeInfo if we don't want to pass it, instead call a ctor which doesn't need it. In addition, remove inner_scope from ctors and adjust it explicitly afterwards. It's confusing that some ctors get passed inner scopes and some outer scopes. BUG=v8:5209 ========== to ========== Scopes: simplify scope creation. With scopes: Don't call the ctor which wants a ScopeInfo if we don't want to pass it, instead call a ctor which doesn't need it. In addition, remove inner_scope from ctors and adjust it explicitly afterwards. It's confusing that some ctors get passed inner scopes and some outer scopes. BUG=v8:5209 Committed: https://crrev.com/7eaeb5aea51a8c1858f39da4ad6539c01711b871 Cr-Commit-Position: refs/heads/master@{#38859} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/7eaeb5aea51a8c1858f39da4ad6539c01711b871 Cr-Commit-Position: refs/heads/master@{#38859} |
