Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: grit/format/policy_templates/writers/reg_writer.py

Issue 227073006: Added a policy writer for iOS Plists. (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: grit/format/policy_templates/writers/reg_writer.py
===================================================================
--- grit/format/policy_templates/writers/reg_writer.py (revision 158)
+++ grit/format/policy_templates/writers/reg_writer.py (working copy)
@@ -4,6 +4,8 @@
# found in the LICENSE file.
+import json
+
from grit.format.policy_templates.writers import template_writer
@@ -64,9 +66,10 @@
i = i + 1
else:
self._StartBlock(key, None, list)
- if policy['type'] in ('string', 'dict'):
- escaped_str = self._EscapeRegString(str(example_value))
- example_value_str = '"' + escaped_str + '"'
+ if policy['type'] in ('string', 'string-enum', 'dict'):
+ example_value_str = json.dumps(example_value, sort_keys=True)
+ if policy['type'] == 'dict':
+ example_value_str = '"%s"' % example_value_str
elif policy['type'] == 'main':
if example_value == True:
example_value_str = 'dword:00000001'
@@ -74,8 +77,6 @@
example_value_str = 'dword:00000000'
elif policy['type'] in ('int', 'int-enum'):
example_value_str = 'dword:%08x' % example_value
- elif policy['type'] == 'string-enum':
- example_value_str = '"%s"' % example_value
else:
raise Exception('unknown policy type %s:' % policy['type'])
« no previous file with comments | « grit/format/policy_templates/writers/plist_writer.py ('k') | grit/format/policy_templates/writers/reg_writer_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698