Reland of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory

Reland of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory (patchset #1 id:1 of https://codereview.chromium.org/2263183002/ )

Reason for revert:
Identified and fixed timestamp problem.

Original issue's description:
> Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory (patchset #5 id:80001 of https://codereview.chromium.org/2244213002/ )
>
> Reason for revert:
> Somehow breaks timestamping. Reverting for investigation. To reproduce, run
>
> ./browser_tests --gtest_filter='WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest*' --run-manual --ui-test-action-max-timeout=200000
>
> This produces lots of warnings like
>
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp (3680861906110 <= 3680861906110) for incoming frame. Dropping.
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp (3680861906042 <= 3680861906042) for incoming frame. Dropping.
>
> Original issue's description:
> > Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
> >
> > Instead, use the AdaptFrame and OnFrame methods of the VideoCapturer
> > base class.
> >
> > This cl also applies the new timestamp aligner logic, to translate
> > Chrome's camera timestamps into the timescale of rtc::TimeMicros(). No
> > other change in behavior is intended.
> >
> > BUG=webrtc:5682, webrtc:5740, 516700
> >
> > Committed: https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f
> > Cr-Commit-Position: refs/heads/master@{#413093}
>
> TBR=perkj@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:5682, webrtc:5740, 516700
>
> Committed: https://crrev.com/e977fbdcd25a49046e23976dfe2f0a667c4ad037
> Cr-Commit-Position: refs/heads/master@{#413444}

BUG=webrtc:5682, webrtc:5740, 516700
Committed: https://crrev.com/918a16ff0f94202936bde994cf7885a0780894ae
Cr-Commit-Position: refs/heads/master@{#414986}

[nisse-chromium (ooo August 14), 2016-08-23 10:03:28]

Created Reland of Delete the class
WebRtcVideoCapturerAdapter::MediaVideoFrameFactory

[nisse-chromium (ooo August 14), 2016-08-23 10:51:09]

Description was changed from

==========
Reland of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #1 id:1 of https://codereview.chromium.org/2263183002/ )

Reason for revert:
Identified timestamp problem. Intending to fix and reland.

Original issue's description:
> Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #5 id:80001 of https://codereview.chromium.org/2244213002/ )
> 
> Reason for revert:
> Somehow breaks timestamping. Reverting for investigation. To reproduce, run
> 
> ./browser_tests
--gtest_filter='WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest*'
--run-manual --ui-test-action-max-timeout=200000
> 
> This produces lots of warnings like
> 
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906110 <= 3680861906110) for incoming frame. Dropping.
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906042 <= 3680861906042) for incoming frame. Dropping.
> 
> Original issue's description:
> > Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
> >
> > Instead, use the AdaptFrame and OnFrame methods of the VideoCapturer
> > base class.
> >
> > This cl also applies the new timestamp aligner logic, to translate
> > Chrome's camera timestamps into the timescale of rtc::TimeMicros(). No
> > other change in behavior is intended.
> >
> > BUG=webrtc:5682, webrtc:5740, 516700
> >
> > Committed: https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f
> > Cr-Commit-Position: refs/heads/master@{#413093}
> 
> TBR=perkj@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:5682, webrtc:5740, 516700
> 
> Committed: https://crrev.com/e977fbdcd25a49046e23976dfe2f0a667c4ad037
> Cr-Commit-Position: refs/heads/master@{#413444}

TBR=perkj@chromium.org,kjellander@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5682, webrtc:5740, 516700
==========

to

==========
Reland of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #1 id:1 of https://codereview.chromium.org/2263183002/ )

Reason for revert:
Identified and fixed timestamp problem.

Original issue's description:
> Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #5 id:80001 of https://codereview.chromium.org/2244213002/ )
> 
> Reason for revert:
> Somehow breaks timestamping. Reverting for investigation. To reproduce, run
> 
> ./browser_tests
--gtest_filter='WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest*'
--run-manual --ui-test-action-max-timeout=200000
> 
> This produces lots of warnings like
> 
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906110 <= 3680861906110) for incoming frame. Dropping.
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906042 <= 3680861906042) for incoming frame. Dropping.
> 
> Original issue's description:
> > Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
> >
> > Instead, use the AdaptFrame and OnFrame methods of the VideoCapturer
> > base class.
> >
> > This cl also applies the new timestamp aligner logic, to translate
> > Chrome's camera timestamps into the timescale of rtc::TimeMicros(). No
> > other change in behavior is intended.
> >
> > BUG=webrtc:5682, webrtc:5740, 516700
> >
> > Committed: https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f
> > Cr-Commit-Position: refs/heads/master@{#413093}
> 
> TBR=perkj@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:5682, webrtc:5740, 516700
> 
> Committed: https://crrev.com/e977fbdcd25a49046e23976dfe2f0a667c4ad037
> Cr-Commit-Position: refs/heads/master@{#413444}

BUG=webrtc:5682, webrtc:5740, 516700
==========

[kjellander_chromium, 2016-08-23 12:45:57]

lgtm, but wait for Per's approval.

[perkj_chrome, 2016-08-23 18:29:31]

lgtm

https://codereview.chromium.org/2270723002/diff/100001/content/renderer/media...
File content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc (right):

https://codereview.chromium.org/2270723002/diff/100001/content/renderer/media...
content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc:143:
webrtc::kVideoRotation_0, translated_camera_time_us),
scary bug.

[nisse-chromium (ooo August 14), 2016-08-24 06:49:16]

On 2016/08/23 18:29:31, perkj_chrome wrote:
> lgtm
> 
>
https://codereview.chromium.org/2270723002/diff/100001/content/renderer/media...
> File content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc (right):
> 
>
https://codereview.chromium.org/2270723002/diff/100001/content/renderer/media...
> content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc:143:
> webrtc::kVideoRotation_0, translated_camera_time_us),
> scary bug.

When I introduced the us constructor, we had to keep the old ns constructor for
backwards compatibility. And to make them distinct, we found no better way than
to use different argument ordering. Which I didn't particularly like even back
then... 

I'm thinking maybe it's best to wait with this reland until after the imminent
chrome cut. Agree?

[nisse-chromium (ooo August 14), 2016-08-29 07:53:55]

The CQ bit was checked by nisse@chromium.org

[commit-bot: I haz the power, 2016-08-29 07:54:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 09:07:10]

Description was changed from

==========
Reland of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #1 id:1 of https://codereview.chromium.org/2263183002/ )

Reason for revert:
Identified and fixed timestamp problem.

Original issue's description:
> Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #5 id:80001 of https://codereview.chromium.org/2244213002/ )
> 
> Reason for revert:
> Somehow breaks timestamping. Reverting for investigation. To reproduce, run
> 
> ./browser_tests
--gtest_filter='WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest*'
--run-manual --ui-test-action-max-timeout=200000
> 
> This produces lots of warnings like
> 
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906110 <= 3680861906110) for incoming frame. Dropping.
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906042 <= 3680861906042) for incoming frame. Dropping.
> 
> Original issue's description:
> > Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
> >
> > Instead, use the AdaptFrame and OnFrame methods of the VideoCapturer
> > base class.
> >
> > This cl also applies the new timestamp aligner logic, to translate
> > Chrome's camera timestamps into the timescale of rtc::TimeMicros(). No
> > other change in behavior is intended.
> >
> > BUG=webrtc:5682, webrtc:5740, 516700
> >
> > Committed: https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f
> > Cr-Commit-Position: refs/heads/master@{#413093}
> 
> TBR=perkj@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:5682, webrtc:5740, 516700
> 
> Committed: https://crrev.com/e977fbdcd25a49046e23976dfe2f0a667c4ad037
> Cr-Commit-Position: refs/heads/master@{#413444}

BUG=webrtc:5682, webrtc:5740, 516700
==========

to

==========
Reland of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #1 id:1 of https://codereview.chromium.org/2263183002/ )

Reason for revert:
Identified and fixed timestamp problem.

Original issue's description:
> Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #5 id:80001 of https://codereview.chromium.org/2244213002/ )
> 
> Reason for revert:
> Somehow breaks timestamping. Reverting for investigation. To reproduce, run
> 
> ./browser_tests
--gtest_filter='WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest*'
--run-manual --ui-test-action-max-timeout=200000
> 
> This produces lots of warnings like
> 
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906110 <= 3680861906110) for incoming frame. Dropping.
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906042 <= 3680861906042) for incoming frame. Dropping.
> 
> Original issue's description:
> > Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
> >
> > Instead, use the AdaptFrame and OnFrame methods of the VideoCapturer
> > base class.
> >
> > This cl also applies the new timestamp aligner logic, to translate
> > Chrome's camera timestamps into the timescale of rtc::TimeMicros(). No
> > other change in behavior is intended.
> >
> > BUG=webrtc:5682, webrtc:5740, 516700
> >
> > Committed: https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f
> > Cr-Commit-Position: refs/heads/master@{#413093}
> 
> TBR=perkj@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:5682, webrtc:5740, 516700
> 
> Committed: https://crrev.com/e977fbdcd25a49046e23976dfe2f0a667c4ad037
> Cr-Commit-Position: refs/heads/master@{#413444}

BUG=webrtc:5682, webrtc:5740, 516700
==========

[commit-bot: I haz the power, 2016-08-29 09:07:12]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-08-29 09:10:45]

Description was changed from

==========
Reland of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #1 id:1 of https://codereview.chromium.org/2263183002/ )

Reason for revert:
Identified and fixed timestamp problem.

Original issue's description:
> Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #5 id:80001 of https://codereview.chromium.org/2244213002/ )
> 
> Reason for revert:
> Somehow breaks timestamping. Reverting for investigation. To reproduce, run
> 
> ./browser_tests
--gtest_filter='WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest*'
--run-manual --ui-test-action-max-timeout=200000
> 
> This produces lots of warnings like
> 
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906110 <= 3680861906110) for incoming frame. Dropping.
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906042 <= 3680861906042) for incoming frame. Dropping.
> 
> Original issue's description:
> > Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
> >
> > Instead, use the AdaptFrame and OnFrame methods of the VideoCapturer
> > base class.
> >
> > This cl also applies the new timestamp aligner logic, to translate
> > Chrome's camera timestamps into the timescale of rtc::TimeMicros(). No
> > other change in behavior is intended.
> >
> > BUG=webrtc:5682, webrtc:5740, 516700
> >
> > Committed: https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f
> > Cr-Commit-Position: refs/heads/master@{#413093}
> 
> TBR=perkj@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:5682, webrtc:5740, 516700
> 
> Committed: https://crrev.com/e977fbdcd25a49046e23976dfe2f0a667c4ad037
> Cr-Commit-Position: refs/heads/master@{#413444}

BUG=webrtc:5682, webrtc:5740, 516700
==========

to

==========
Reland of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #1 id:1 of https://codereview.chromium.org/2263183002/ )

Reason for revert:
Identified and fixed timestamp problem.

Original issue's description:
> Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #5 id:80001 of https://codereview.chromium.org/2244213002/ )
>
> Reason for revert:
> Somehow breaks timestamping. Reverting for investigation. To reproduce, run
>
> ./browser_tests
--gtest_filter='WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest*'
--run-manual --ui-test-action-max-timeout=200000
>
> This produces lots of warnings like
>
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906110 <= 3680861906110) for incoming frame. Dropping.
> [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906042 <= 3680861906042) for incoming frame. Dropping.
>
> Original issue's description:
> > Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
> >
> > Instead, use the AdaptFrame and OnFrame methods of the VideoCapturer
> > base class.
> >
> > This cl also applies the new timestamp aligner logic, to translate
> > Chrome's camera timestamps into the timescale of rtc::TimeMicros(). No
> > other change in behavior is intended.
> >
> > BUG=webrtc:5682, webrtc:5740, 516700
> >
> > Committed: https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f
> > Cr-Commit-Position: refs/heads/master@{#413093}
>
> TBR=perkj@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:5682, webrtc:5740, 516700
>
> Committed: https://crrev.com/e977fbdcd25a49046e23976dfe2f0a667c4ad037
> Cr-Commit-Position: refs/heads/master@{#413444}

BUG=webrtc:5682, webrtc:5740, 516700

Committed: https://crrev.com/918a16ff0f94202936bde994cf7885a0780894ae
Cr-Commit-Position: refs/heads/master@{#414986}
==========

[commit-bot: I haz the power, 2016-08-29 09:10:46]

Patchset 2 (id:??) landed as
https://crrev.com/918a16ff0f94202936bde994cf7885a0780894ae
Cr-Commit-Position: refs/heads/master@{#414986}

[magjed_chromium, 2016-09-08 15:27:52]

A revert of this CL (patchset #2 id:100001) has been created in
https://codereview.chromium.org/2318953006/ by magjed@chromium.org.

The reason for reverting is: This CL breaks CPU adaptation. It should scale to
the adapted resolution, but this CL crops instead. The result looks like zoomed
in video when CPU adaptation kicks in..