Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2270713002: VEA unittest: align input buffers to 128-byte boundary on ARM only. (Closed)

Created:
4 years, 4 months ago by Pawel Osciak
Modified:
4 years, 4 months ago
Reviewers:
kcwu, henryhsu
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VEA unittest: align input buffers to 128-byte boundary on ARM only. Some ARM platforms may require 128-byte alignment for physical buffers. Modify veatest to align to 128 bytes instead of 64 and use a constant for alignment size. Also, don't require this alignment on other architectures. BUG=None TEST=veatest on ARM platforms Committed: https://crrev.com/49455c01c8f8de20910a2b5118797fca056acad6 Cr-Commit-Position: refs/heads/master@{#413996}

Patch Set 1 #

Total comments: 2

Patch Set 2 : VEA unittest: align input buffers to 128-byte boundary on ARM only. #

Patch Set 3 : Fix compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -28 lines) Patch
M media/gpu/video_encode_accelerator_unittest.cc View 1 2 8 chunks +34 lines, -28 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Pawel Osciak
4 years, 4 months ago (2016-08-23 09:02:12 UTC) #2
kcwu
https://codereview.chromium.org/2270713002/diff/1/media/gpu/video_encode_accelerator_unittest.cc File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2270713002/diff/1/media/gpu/video_encode_accelerator_unittest.cc#newcode360 media/gpu/video_encode_accelerator_unittest.cc:360: ASSERT_EQ(dest_offset & kPlatformBufferAlignment, 0) (kPlatformBufferAlignment - 1)
4 years, 4 months ago (2016-08-23 09:09:03 UTC) #3
Pawel Osciak
https://codereview.chromium.org/2270713002/diff/1/media/gpu/video_encode_accelerator_unittest.cc File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2270713002/diff/1/media/gpu/video_encode_accelerator_unittest.cc#newcode360 media/gpu/video_encode_accelerator_unittest.cc:360: ASSERT_EQ(dest_offset & kPlatformBufferAlignment, 0) On 2016/08/23 09:09:02, kcwu wrote: ...
4 years, 4 months ago (2016-08-23 09:18:32 UTC) #4
kcwu
lgtm
4 years, 4 months ago (2016-08-23 09:34:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270713002/20001
4 years, 4 months ago (2016-08-23 09:38:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/187880)
4 years, 4 months ago (2016-08-23 10:01:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270713002/40001
4 years, 4 months ago (2016-08-24 06:29:05 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-24 06:32:45 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 06:34:38 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/49455c01c8f8de20910a2b5118797fca056acad6
Cr-Commit-Position: refs/heads/master@{#413996}

Powered by Google App Engine
This is Rietveld 408576698