Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 22707006: Web Animations CSS: Assert underlying value is not used (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Changed to assert Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/StyleResolver.cpp
diff --git a/Source/core/css/resolver/StyleResolver.cpp b/Source/core/css/resolver/StyleResolver.cpp
index 996285ae47ae034b75e0ec582de59633b31ed04c..f552b7b21a2f7ef74236617e45064151ed3341fe 100644
--- a/Source/core/css/resolver/StyleResolver.cpp
+++ b/Source/core/css/resolver/StyleResolver.cpp
@@ -1162,7 +1162,8 @@ void StyleResolver::applyAnimatedProperties(StyleResolverState& state, const Ele
CSSPropertyID property = iter->key;
if (!isPropertyForPass<pass>(property))
continue;
- RefPtr<AnimatableValue> animatableValue = iter->value->compositeOnto(AnimatableValue::neutralValue());
+ ASSERT_WITH_MESSAGE(!iter->value->dependsOnUnderlyingValue(), "Not yet implemented: An interface for compositing onto the underlying value.");
Steve Block 2013/08/09 04:32:31 Should this be a release assert? I thought we agre
alancutter (OOO until 2018) 2013/08/09 05:46:31 Done.
+ RefPtr<AnimatableValue> animatableValue = iter->value->compositeOnto(0);
if (pass == HighPriorityProperties && property == CSSPropertyLineHeight)
state.setLineHeightValue(toAnimatableNumber(animatableValue.get())->toCSSValue().get());
else

Powered by Google App Engine
This is Rietveld 408576698