Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2270693002:
WebSocket: Consolidate inter-thread synchronous function calls (Closed)
|
Created:
4 years, 4 months ago by nhiroki Modified:
4 years, 4 months ago CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org, yhirano+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWebSocket: Consolidate inter-thread synchronous function calls
Bridge::initialize() should be merged into Bridge::connect() so that we can
reduce the number of inter-thread synchronous function calls.
BUG=640088
Committed: https://crrev.com/9fe7a2928edbd26896aa187deeead6b7509e3df1
Cr-Commit-Position: refs/heads/master@{#413997}
Patch Set 1 #Patch Set 2 : remove duplicate signalWorkerThread() call #Patch Set 3 : remove a unused function declaration #
Total comments: 2
Patch Set 4 : address review comment #
Messages
Total messages: 25 (17 generated)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== WebSocket: Consolidate synchronous function calls BUG=640088 ========== to ========== WebSocket: Consolidate inter-thread synchronous function calls Bridge::initialize() should be merged into Bridge::connect() so that we can reduce the number of inter-thread synchronous function calls. BUG=640088 ==========
Description was changed from ========== WebSocket: Consolidate inter-thread synchronous function calls Bridge::initialize() should be merged into Bridge::connect() so that we can reduce the number of inter-thread synchronous function calls. BUG=640088 ========== to ========== WebSocket: Consolidate inter-thread synchronous function calls Bridge::initialize() should be merged into Bridge::connect() so that we can reduce the number of inter-thread synchronous function calls. BUG=640088 ==========
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
nhiroki@chromium.org changed reviewers: + yhirano@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2270693002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp (right): https://codereview.chromium.org/2270693002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp:206: void Peer::connect(const KURL& url, const String& protocol) How about making this function return a boolean instead of set the result to m_syncHelper?
Thank you. Updated. https://codereview.chromium.org/2270693002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp (right): https://codereview.chromium.org/2270693002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp:206: void Peer::connect(const KURL& url, const String& protocol) On 2016/08/24 04:46:32, yhirano wrote: > How about making this function return a boolean instead of set the result to > m_syncHelper? Done.
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by nhiroki@chromium.org
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
Message was sent while issue was closed.
Description was changed from ========== WebSocket: Consolidate inter-thread synchronous function calls Bridge::initialize() should be merged into Bridge::connect() so that we can reduce the number of inter-thread synchronous function calls. BUG=640088 ========== to ========== WebSocket: Consolidate inter-thread synchronous function calls Bridge::initialize() should be merged into Bridge::connect() so that we can reduce the number of inter-thread synchronous function calls. BUG=640088 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== WebSocket: Consolidate inter-thread synchronous function calls Bridge::initialize() should be merged into Bridge::connect() so that we can reduce the number of inter-thread synchronous function calls. BUG=640088 ========== to ========== WebSocket: Consolidate inter-thread synchronous function calls Bridge::initialize() should be merged into Bridge::connect() so that we can reduce the number of inter-thread synchronous function calls. BUG=640088 Committed: https://crrev.com/9fe7a2928edbd26896aa187deeead6b7509e3df1 Cr-Commit-Position: refs/heads/master@{#413997} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/9fe7a2928edbd26896aa187deeead6b7509e3df1 Cr-Commit-Position: refs/heads/master@{#413997} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
