Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2270683002:
Fix compile error when AUTOSIZING_DOM_DEBUG_INFO is defined. (Closed)
|
Created:
4 years, 4 months ago by cathiechentx Modified:
4 years, 3 months ago CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix compile error when AUTOSIZING_DOM_DEBUG_INFO is defined.
the argument WebTraceLocation is missed when calling postTask().
See the definition of postTask in Document.h:
void postTask(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>, const String& taskNameForInstrumentation = emptyString()) override;
BUG=
Committed: https://crrev.com/9459688bc2e14e90d28550e7a8d32e85033de01b
Cr-Commit-Position: refs/heads/master@{#414046}
Patch Set 1 #Messages
Total messages: 20 (9 generated)
Description was changed from ========== Fix compile error when AUTOSIZING_DOM_DEBUG_INFO is defined. the argument WebTraceLocation is missed when calling postTask(). See the definition of postTask in Document.h: void postTask(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>, const String& taskNameForInstrumentation = emptyString()) override; BUG= ========== to ========== Fix compile error when AUTOSIZING_DOM_DEBUG_INFO is defined. the argument WebTraceLocation is missed when calling postTask(). See the definition of postTask in Document.h: void postTask(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>, const String& taskNameForInstrumentation = emptyString()) override; BUG= ==========
cathiechen@tencent.com changed reviewers: + jamesxwei@tencent.com, pdr@chromium.org, skyostil@chromium.org
lgtm.
Really cool to see contributions from Tencent! I verified cathiechen@tencent.com has signed the CLA. LGTM here as well.
On 2016/08/23 17:53:29, pdr. wrote: > Really cool to see contributions from Tencent! I verified mailto:cathiechen@tencent.com > has signed the CLA. > > LGTM here as well. Thanks for your reply, pdr. and Sami. it's so exciting to work here;)
The CQ bit was checked by cathiechen@tencent.com
The CQ bit was unchecked by cathiechen@tencent.com
The CQ bit was checked by cathiechen@tencent.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
The author cathiechen@tencent.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The CQ bit was checked by cathiechen@tencent.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix compile error when AUTOSIZING_DOM_DEBUG_INFO is defined. the argument WebTraceLocation is missed when calling postTask(). See the definition of postTask in Document.h: void postTask(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>, const String& taskNameForInstrumentation = emptyString()) override; BUG= ========== to ========== Fix compile error when AUTOSIZING_DOM_DEBUG_INFO is defined. the argument WebTraceLocation is missed when calling postTask(). See the definition of postTask in Document.h: void postTask(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>, const String& taskNameForInstrumentation = emptyString()) override; BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix compile error when AUTOSIZING_DOM_DEBUG_INFO is defined. the argument WebTraceLocation is missed when calling postTask(). See the definition of postTask in Document.h: void postTask(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>, const String& taskNameForInstrumentation = emptyString()) override; BUG= ========== to ========== Fix compile error when AUTOSIZING_DOM_DEBUG_INFO is defined. the argument WebTraceLocation is missed when calling postTask(). See the definition of postTask in Document.h: void postTask(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>, const String& taskNameForInstrumentation = emptyString()) override; BUG= Committed: https://crrev.com/9459688bc2e14e90d28550e7a8d32e85033de01b Cr-Commit-Position: refs/heads/master@{#414046} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9459688bc2e14e90d28550e7a8d32e85033de01b Cr-Commit-Position: refs/heads/master@{#414046}
Message was sent while issue was closed.
On 2016/08/24 at 02:29:11, commit-bot wrote: > The author cathiechen@tencent.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA. I'm not sure what's up here. I filed https://crbug.com/640663
Message was sent while issue was closed.
On 2016/08/24 17:21:09, pdr. wrote: > On 2016/08/24 at 02:29:11, commit-bot wrote: > > The author mailto:cathiechen@tencent.com has not signed Google Contributor License > Agreement. Please visit https://cla.developers.google.com to sign and manage > CLA. > > I'm not sure what's up here. I filed https://crbug.com/640663 Thanks pdr. I'll explain it in https://crbug.com/640663 |
