Selection API of INPUT/TEXTAREA should not update FrameSelection without focusing.

Selection API of INPUT/TEXTAREA should not update FrameSelection without focusing.

We had an option SelectionOption::ChangeSelection, which updates FrameSelection
regardless of focus state. It's harmful because it caused focus-FrameSelection
mismatch.  We don't need such option, and ChangeSelectionIfFocused should be the
default.

This CL needs to update many layout tests because they assumed
setSelectionRange() updated FrameSelection.

BUG=637860
Committed: https://crrev.com/530015339e3f6572d239432b69f77ebca1492f73
Cr-Commit-Position: refs/heads/master@{#413695}

[tkent, 2016-08-23 05:05:56]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 05:06:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-23 05:47:18]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2016-08-23 05:47:36]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-23 05:47:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-23 05:48:31]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2016-08-23 05:48:32]

yoichio@, yosin@, would you review this please?
Note that converting affected tests to testharness.js is not a scope of this CL.

[yosin_UTC9, 2016-08-23 06:01:36]

lgtm

Awesome!
Thanks for quick finding of root cause and fixing!

[tkent, 2016-08-23 06:59:32]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 06:59:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 08:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 08:23:32]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-08-23 08:28:10]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-08-23 08:28:11]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2270663002/#ps40001
(title: "Adjust more tests")

[commit-bot: I haz the power, 2016-08-23 08:28:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 08:33:24]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-23 08:34:50]

Description was changed from

==========
Selection API of INPUT/TEXTAREA should not update FrameSelection without
focusing.

We had an option SelectionOption::ChangeSelection, which updates FrameSelection
regardless of focus state. It's harmful because it caused focus-FrameSelection
mismatch.  We don't need such option, and ChangeSelectionIfFocused should be the
default.

This CL needs to update many layout tests because they assumed
setSelectionRange() updated FrameSelection.

BUG=637860
==========

to

==========
Selection API of INPUT/TEXTAREA should not update FrameSelection without
focusing.

We had an option SelectionOption::ChangeSelection, which updates FrameSelection
regardless of focus state. It's harmful because it caused focus-FrameSelection
mismatch.  We don't need such option, and ChangeSelectionIfFocused should be the
default.

This CL needs to update many layout tests because they assumed
setSelectionRange() updated FrameSelection.

BUG=637860

Committed: https://crrev.com/530015339e3f6572d239432b69f77ebca1492f73
Cr-Commit-Position: refs/heads/master@{#413695}
==========

[commit-bot: I haz the power, 2016-08-23 08:34:52]

Patchset 2 (id:??) landed as
https://crrev.com/530015339e3f6572d239432b69f77ebca1492f73
Cr-Commit-Position: refs/heads/master@{#413695}