Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2270633004:
import remote_build_metadata.py. (Closed)
|
Created:
4 years, 4 months ago by Yoshisato Yanagisawa Modified:
4 years, 3 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionimport remote_build_metadata.py.
In addition to compare_build_artifacts.py, remote_build_metadata.py
is also migrated to src/tools/determinism.
TBR=maruel@chromium.org
BUG=314403
Committed: https://crrev.com/b25f723a958671a8d908ca6c7dcc4eb6deb02a56
Cr-Commit-Position: refs/heads/master@{#414132}
Patch Set 1 #
Total comments: 2
Patch Set 2 : no need to pass --src_dir. #Patch Set 3 : dirname(dirname(x) isntead of join(x, '..', '..') #Messages
Total messages: 20 (9 generated)
yyanagisawa@chromium.org changed reviewers: + dpranke@chromium.org, maruel@chromium.org
As suggested in https://codereview.chromium.org/2260733002/, let me import remove_build_metadata.py. Since I do not think we can run the script without --build_dir, I made it mandatory.
lgtm with simplification https://codereview.chromium.org/2270633004/diff/1/tools/determinism/remove_bu... File tools/determinism/remove_build_metadata.py (right): https://codereview.chromium.org/2270633004/diff/1/tools/determinism/remove_bu... tools/determinism/remove_build_metadata.py:145: parser.add_option('--src-dir', help='The source directory.') you can remove this flag and make it src_dir == os.path.dirname(os.path.dirname(BASE_DIR))
https://codereview.chromium.org/2270633004/diff/1/tools/determinism/remove_bu... File tools/determinism/remove_build_metadata.py (right): https://codereview.chromium.org/2270633004/diff/1/tools/determinism/remove_bu... tools/determinism/remove_build_metadata.py:145: parser.add_option('--src-dir', help='The source directory.') On 2016/08/24 02:15:45, M-A Ruel wrote: > you can remove this flag and make it src_dir == > os.path.dirname(os.path.dirname(BASE_DIR)) Done.
lgtm
The CQ bit was checked by maruel@chromium.org
The CQ bit was unchecked by maruel@chromium.org
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== import remote_build_metadata.py. In addition to compare_build_artifacts.py, remote_build_metadata.py is also migrated to src/tools/determinism. BUG=314403 ========== to ========== import remote_build_metadata.py. In addition to compare_build_artifacts.py, remote_build_metadata.py is also migrated to src/tools/determinism. TBR=maruel@chromium.org BUG=314403 ==========
On 2016/08/24 19:44:54, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Changed CL description to TBR so it will commit, I'll send a CL to add an OWNERS file.
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== import remote_build_metadata.py. In addition to compare_build_artifacts.py, remote_build_metadata.py is also migrated to src/tools/determinism. TBR=maruel@chromium.org BUG=314403 ========== to ========== import remote_build_metadata.py. In addition to compare_build_artifacts.py, remote_build_metadata.py is also migrated to src/tools/determinism. TBR=maruel@chromium.org BUG=314403 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== import remote_build_metadata.py. In addition to compare_build_artifacts.py, remote_build_metadata.py is also migrated to src/tools/determinism. TBR=maruel@chromium.org BUG=314403 ========== to ========== import remote_build_metadata.py. In addition to compare_build_artifacts.py, remote_build_metadata.py is also migrated to src/tools/determinism. TBR=maruel@chromium.org BUG=314403 Committed: https://crrev.com/b25f723a958671a8d908ca6c7dcc4eb6deb02a56 Cr-Commit-Position: refs/heads/master@{#414132} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b25f723a958671a8d908ca6c7dcc4eb6deb02a56 Cr-Commit-Position: refs/heads/master@{#414132} |
