Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2270633003: DevTools: Warn when non-top context is selected. (Closed)

Created:
4 years, 4 months ago by einbinder
Modified:
4 years, 3 months ago
Reviewers:
paulirish, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Warn when non-top context is selected. BUG=640268 Committed: https://crrev.com/a2080e2379d7b4f81f63d129491e4795187f09c7 Cr-Commit-Position: refs/heads/master@{#418159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js View 4 chunks +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
einbinder
Ptal, I can make the code smaller if we want, but I think this is ...
4 years, 4 months ago (2016-08-23 19:36:29 UTC) #2
pfeldman
lgtm
4 years, 3 months ago (2016-09-07 18:39:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270633003/1
4 years, 3 months ago (2016-09-13 02:17:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 03:29:38 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 03:31:59 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a2080e2379d7b4f81f63d129491e4795187f09c7
Cr-Commit-Position: refs/heads/master@{#418159}

Powered by Google App Engine
This is Rietveld 408576698