Implementation of the DeviceInfo get API.

chrome/browser/sync/glue/device_info.cc

Index: chrome/browser/sync/glue/device_info.cc
diff --git a/chrome/browser/sync/glue/device_info.cc b/chrome/browser/sync/glue/device_info.cc
index 486c8bb5e2752d906686ba65e954f2db114ee35f..38d5aeefa3748711ba23be481775085f57feec31 100644
--- a/chrome/browser/sync/glue/device_info.cc
+++ b/chrome/browser/sync/glue/device_info.cc
@@ -44,22 +44,35 @@ std::string ChannelToString(chrome::VersionInfo::Channel channel) {
 std::string DeviceTypeToString(sync_pb::SyncEnums::DeviceType device_type) {
   switch (device_type) {
     case sync_pb::SyncEnums_DeviceType_TYPE_WIN:
-      return "WIN";
     case sync_pb::SyncEnums_DeviceType_TYPE_MAC:
-      return "MAC";
     case sync_pb::SyncEnums_DeviceType_TYPE_LINUX:
-      return "LINUX";
     case sync_pb::SyncEnums_DeviceType_TYPE_CROS:
-      return "CHROME OS";
-    case sync_pb::SyncEnums_DeviceType_TYPE_OTHER:
-      return "OTHER";
+      return "desktop_or_laptop";
     case sync_pb::SyncEnums_DeviceType_TYPE_PHONE:
-      return "PHONE";
+      return "phone";
     case sync_pb::SyncEnums_DeviceType_TYPE_TABLET:
-      return "TABLET";
+      return "tablet";
     default:
-      NOTREACHED();
-      return "UNKNOWN";
+      return "unknown";
+  }
+}
+
+std::string GetOS(sync_pb::SyncEnums::DeviceType device_type) {
+  switch (device_type) {
+    case sync_pb::SyncEnums_DeviceType_TYPE_WIN:
+      return "win";
+    case sync_pb::SyncEnums_DeviceType_TYPE_MAC:
+      return "mac";
+    case sync_pb::SyncEnums_DeviceType_TYPE_LINUX:
+      return "linux";
+    case sync_pb::SyncEnums_DeviceType_TYPE_CROS:
+      return "chrome_os";
+    case sync_pb::SyncEnums_DeviceType_TYPE_PHONE:
+    case sync_pb::SyncEnums_DeviceType_TYPE_TABLET:
+      // TODO(lipalani): Add support for ios phones and tablets.

[Nicolas Zea, 2013/08/10 00:49:20]

nit: mention the bug tracking this work as well.

[lipalani1, 2013/08/13 22:42:37]

Done.

+      return "android";
+    default:
+      return "unknown";
   }
 }
 
@@ -172,10 +185,10 @@ std::string DeviceInfo::MakeUserAgentForSyncApi(
 
 base::DictionaryValue* DeviceInfo::ToValue() {
   base::DictionaryValue* value = new base::DictionaryValue();
-  value->SetString("Id", public_id_);
-  value->SetString("Client Name", client_name_);
-  value->SetString("Chrome Version", chrome_version_);
-  value->SetString("Sync User Agent", sync_user_agent_);
+  value->SetString("id", public_id_);
+  value->SetString("name", client_name_);
+  value->SetString("chromeVersion", chrome_version_);
+  value->SetString("OS", GetOS(device_type_));

[Matt Perry, 2013/08/12 22:21:01]

lowercase "os" (notice "id" is lowercase)

[lipalani1, 2013/08/13 22:42:37]

Done.

   value->SetString("Device Type", DeviceTypeToString(device_type_));
   return value;
 }