ImageCapture: support exposure mode configuration

ImageCapture: support exposure mode configuration

This CL implements support for (auto)exposure
configuration, following discussion in [1]:

- s/FocusMode/MeteringMode/ and reusing it for
 |exposureMode| in idl, mojom and Java enum.

- this reuse prompts refactoring some code into
 anonymous-ns static functions.

- Android's |mAreaOfInterest| is cleared when the
 user passes "unavailable" in either focus
 or exposure

 (note: focus and exposure shared the points of
  interest as is customary in camera apps).

BUG=368381, 518807
[1] https://github.com/w3c/mediacapture-image/issues/49

Committed: https://crrev.com/7a427cc2cc70a31893ebca9971de052efc25ab01
Cr-Commit-Position: refs/heads/master@{#414254}

[mcasas, 2016-08-24 00:23:11]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-08-24 15:30:30]

Description was changed from

==========
ImageCapture: support exposure mode configuration

wip

BUG=368381,518807
==========

to

==========
ImageCapture: support exposure mode configuration

This CL implements support for (auto)exposure
configuration, following discussion in [1]:

- s/FocusMode/MeteringMode/ and reusing it for
 |exposureMode| in idl, mojom and Java enum.

- this reuse prompts refactoring some code into
 anonymous-ns static functions.

- Android's |mAreaOfInterest| is cleared when the 
 user passes "unavailable" in either focus
 or exposure

 (note: focus and exposure shared the points of 
  interest as is customary in camera apps).

BUG=368381,518807

[1] https://github.com/w3c/mediacapture-image/issues/49
==========

[mcasas, 2016-08-24 15:30:42]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-08-24 15:30:47]

Patchset #1 (id:40001) has been deleted

[mcasas, 2016-08-24 15:39:02]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org, tsepez@chromium.org

[mcasas, 2016-08-24 15:39:02]

tsepez@ image_capture.mojom

reillyg@ PTAL

[mcasas, 2016-08-24 15:50:22]

Patchset #1 (id:60001) has been deleted

[Tom Sepez, 2016-08-24 16:29:02]

mojom lgtm

[Reilly Grant (use Gerrit), 2016-08-24 18:14:03]

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
(right):

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:356:
// exposure compensation is locked, case in which we consider it as FIXED.
*in which case

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
(right):

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:664:
(exposureMode != AndroidMeteringMode.NOT_SET) ? exposureMode : mExposureMode;
This pattern is a little weird. I'd prefer:

if (focusMode != AndroidMeteringMode.NOT_SET) mFocusMode = focusMode;
if (exposureMode != AndroidMeteringMode.NOT_SET) mExposureMode = exposureMode;

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
File media/capture/video/android/video_capture_device_android.cc (right):

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
media/capture/video/android/video_capture_device_android.cc:54: }
Use switch statements for these functions?

https://codereview.chromium.org/2270563006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right):

https://codereview.chromium.org/2270563006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:38:
media::mojom::blink::MeteringMode MeteringModeBlinkToMojo(const String&
blinkMode)
This isn't really Blink's metering mode. I'd name this parseMeteringMode().

https://codereview.chromium.org/2270563006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp
(right):

https://codereview.chromium.org/2270563006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp:11: String
MeteringModeToString(media::mojom::blink::MeteringMode mode)
Function names start lower-case in Blink.

[mcasas, 2016-08-24 18:35:16]

Patchset #4 (id:140001) has been deleted

[mcasas, 2016-08-24 18:36:23]

reillyg@ PTAL

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
(right):

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:356:
// exposure compensation is locked, case in which we consider it as FIXED.
On 2016/08/24 18:14:02, Reilly Grant wrote:
> *in which case

Done.

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
(right):

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:664:
(exposureMode != AndroidMeteringMode.NOT_SET) ? exposureMode : mExposureMode;
On 2016/08/24 18:14:03, Reilly Grant wrote:
> This pattern is a little weird. I'd prefer:
> 
> if (focusMode != AndroidMeteringMode.NOT_SET) mFocusMode = focusMode;
> if (exposureMode != AndroidMeteringMode.NOT_SET) mExposureMode = exposureMode;

Done.

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
File media/capture/video/android/video_capture_device_android.cc (right):

https://codereview.chromium.org/2270563006/diff/100001/media/capture/video/an...
media/capture/video/android/video_capture_device_android.cc:54: }
On 2016/08/24 18:14:03, Reilly Grant wrote:
> Use switch statements for these functions?

Ooops yes, done.

https://codereview.chromium.org/2270563006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right):

https://codereview.chromium.org/2270563006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:38:
media::mojom::blink::MeteringMode MeteringModeBlinkToMojo(const String&
blinkMode)
On 2016/08/24 18:14:03, Reilly Grant wrote:
> This isn't really Blink's metering mode. I'd name this parseMeteringMode().

Done.

https://codereview.chromium.org/2270563006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp
(right):

https://codereview.chromium.org/2270563006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp:11: String
MeteringModeToString(media::mojom::blink::MeteringMode mode)
On 2016/08/24 18:14:03, Reilly Grant wrote:
> Function names start lower-case in Blink.

Done.

[Reilly Grant (use Gerrit), 2016-08-24 19:48:50]

lgtm

[mcasas, 2016-08-24 20:08:21]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-08-24 20:08:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2270563006/#ps160001
(title: "reillyg@ comments")

[commit-bot: I haz the power, 2016-08-24 20:08:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 23:34:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:34:49]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mcasas, 2016-08-24 23:57:15]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:58:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 02:14:49]

Description was changed from

==========
ImageCapture: support exposure mode configuration

This CL implements support for (auto)exposure
configuration, following discussion in [1]:

- s/FocusMode/MeteringMode/ and reusing it for
 |exposureMode| in idl, mojom and Java enum.

- this reuse prompts refactoring some code into
 anonymous-ns static functions.

- Android's |mAreaOfInterest| is cleared when the 
 user passes "unavailable" in either focus
 or exposure

 (note: focus and exposure shared the points of 
  interest as is customary in camera apps).

BUG=368381,518807

[1] https://github.com/w3c/mediacapture-image/issues/49
==========

to

==========
ImageCapture: support exposure mode configuration

This CL implements support for (auto)exposure
configuration, following discussion in [1]:

- s/FocusMode/MeteringMode/ and reusing it for
 |exposureMode| in idl, mojom and Java enum.

- this reuse prompts refactoring some code into
 anonymous-ns static functions.

- Android's |mAreaOfInterest| is cleared when the 
 user passes "unavailable" in either focus
 or exposure

 (note: focus and exposure shared the points of 
  interest as is customary in camera apps).

BUG=368381,518807

[1] https://github.com/w3c/mediacapture-image/issues/49
==========

[commit-bot: I haz the power, 2016-08-25 02:14:50]

Committed patchset #4 (id:160001)

[commit-bot: I haz the power, 2016-08-25 02:18:31]

Description was changed from

==========
ImageCapture: support exposure mode configuration

This CL implements support for (auto)exposure
configuration, following discussion in [1]:

- s/FocusMode/MeteringMode/ and reusing it for
 |exposureMode| in idl, mojom and Java enum.

- this reuse prompts refactoring some code into
 anonymous-ns static functions.

- Android's |mAreaOfInterest| is cleared when the 
 user passes "unavailable" in either focus
 or exposure

 (note: focus and exposure shared the points of 
  interest as is customary in camera apps).

BUG=368381,518807

[1] https://github.com/w3c/mediacapture-image/issues/49
==========

to

==========
ImageCapture: support exposure mode configuration

This CL implements support for (auto)exposure
configuration, following discussion in [1]:

- s/FocusMode/MeteringMode/ and reusing it for
 |exposureMode| in idl, mojom and Java enum.

- this reuse prompts refactoring some code into
 anonymous-ns static functions.

- Android's |mAreaOfInterest| is cleared when the
 user passes "unavailable" in either focus
 or exposure

 (note: focus and exposure shared the points of
  interest as is customary in camera apps).

BUG=368381,518807

[1] https://github.com/w3c/mediacapture-image/issues/49

Committed: https://crrev.com/7a427cc2cc70a31893ebca9971de052efc25ab01
Cr-Commit-Position: refs/heads/master@{#414254}
==========

[commit-bot: I haz the power, 2016-08-25 02:18:32]

Patchset 4 (id:??) landed as
https://crrev.com/7a427cc2cc70a31893ebca9971de052efc25ab01
Cr-Commit-Position: refs/heads/master@{#414254}