Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py

Issue 2270563005: Clean up some discrepancies in the perf recipe configs (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: You know, expectations and stuff. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py b/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py
index c584b8611fea868ba14b1b8810154a33740e8593..f22f6c2c2a462743dfddf7dbcf5e18af4ecc9d29 100644
--- a/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py
+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
from . import chromium_perf
+from . import steps
import DEPS
CHROMIUM_CONFIG_CTX = DEPS['chromium'].CONFIG_CTX
@@ -31,15 +32,17 @@ def _AddBuildSpec(name, perf_id, platform, config_name='chromium_perf',
config_name, perf_id, platform, target_bits)
-def _AddTestSpec(name, perf_id, platform,
- parent_builder=None, target_bits=64):
- parent_buildername = (parent_builder or
- chromium_perf.builders[platform][target_bits])
- spec = chromium_perf.TestSpec('chromium_perf', parent_buildername, perf_id,
- platform, target_bits, 0, 1, 1)
- if not parent_builder:
+def _AddTestSpec(name, perf_id, platform, parent_buildername=None, target_bits=64):
RobertoCN 2016/08/30 21:08:01 Is this line long, or is my browser wrapping it wr
dtu 2016/08/31 08:36:34 Done.
+ tests = [steps.DynamicPerfTests(
+ perf_id, platform, target_bits,
+ num_device_shards=1, num_host_shards=1, shard_index=0)]
+
+ spec = chromium_perf.TestSpec(
+ 'chromium_perf', platform, target_bits,
+ parent_buildername=parent_buildername, tests=tests)
+ if not parent_buildername:
spec['parent_mastername'] = 'chromium.perf'
- spec['disable_tests'] = True
+
SPEC['builders'][name] = spec
@@ -60,4 +63,4 @@ _AddTestSpec('Mac Test Retina Perf', 'mac-test-retina', 'mac')
_AddBuildSpec('Win Clang Builder', 'win-clang-builder', 'win',
config_name='chromium_perf_clang', target_bits=32)
_AddTestSpec('Win Clang Perf', 'chromium-win-clang', 'win',
- parent_builder='Win Clang Builder', target_bits=32)
+ parent_buildername='Win Clang Builder', target_bits=32)

Powered by Google App Engine
This is Rietveld 408576698