Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2941)

Unified Diff: chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc

Issue 2270543003: Display Window Icon In Picker UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve Comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc
diff --git a/chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc b/chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc
index 0731c5cef44efcef5b212f2fce76694a5795503a..601f3aaa918a8064353cde0ee6b484cb34a22ac6 100644
--- a/chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc
+++ b/chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc
@@ -23,6 +23,7 @@ DesktopMediaSourceViewStyle::DesktopMediaSourceViewStyle(
DesktopMediaSourceViewStyle::DesktopMediaSourceViewStyle(
int columns,
const gfx::Size& item_size,
+ const gfx::Rect& icon_rect,
const gfx::Rect& label_rect,
gfx::HorizontalAlignment text_alignment,
const gfx::Rect& image_rect,
@@ -30,6 +31,7 @@ DesktopMediaSourceViewStyle::DesktopMediaSourceViewStyle(
int focus_rectangle_inset)
: columns(columns),
item_size(item_size),
+ icon_rect(icon_rect),
label_rect(label_rect),
text_alignment(text_alignment),
image_rect(image_rect),
@@ -43,11 +45,14 @@ DesktopMediaSourceView::DesktopMediaSourceView(
: parent_(parent),
source_id_(source_id),
style_(style),
+ icon_view_(new views::ImageView()),
image_view_(new views::ImageView()),
label_(new views::Label()),
selected_(false) {
+ AddChildView(icon_view_);
AddChildView(image_view_);
AddChildView(label_);
+ icon_view_->set_interactive(false);
image_view_->set_interactive(false);
SetFocusBehavior(FocusBehavior::ALWAYS);
SetStyle(style_);
@@ -66,6 +71,10 @@ void DesktopMediaSourceView::SetThumbnail(const gfx::ImageSkia& thumbnail) {
image_view_->SetImage(thumbnail);
}
+void DesktopMediaSourceView::SetIcon(const gfx::ImageSkia& icon) {
+ icon_view_->SetImage(icon);
+}
+
void DesktopMediaSourceView::SetSelected(bool selected) {
if (selected == selected_)
return;
@@ -127,6 +136,8 @@ void DesktopMediaSourceView::SetStyle(DesktopMediaSourceViewStyle style) {
image_view_->SetBorder(views::Border::CreateSolidBorder(
style_.selection_border_thickness, border_color));
}
+ icon_view_->SetBoundsRect(style_.icon_rect);
+ icon_view_->SetImageSize(style_.icon_rect.size());
label_->SetBoundsRect(style_.label_rect);
label_->SetHorizontalAlignment(style_.text_alignment);
}

Powered by Google App Engine
This is Rietveld 408576698