Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4736)

Unified Diff: chrome/browser/media/window_icon_util_x11.cc

Issue 2270543003: Display Window Icon In Picker UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Error Tracker Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/window_icon_util_x11.cc
diff --git a/chrome/browser/media/window_icon_util_x11.cc b/chrome/browser/media/window_icon_util_x11.cc
index 36462dc229d131d6adbc58c1fadb4b26427e3624..21af64f6b91d7329919c01fe60b084b9a17457bf 100644
--- a/chrome/browser/media/window_icon_util_x11.cc
+++ b/chrome/browser/media/window_icon_util_x11.cc
@@ -7,6 +7,7 @@
#include <X11/Xatom.h>
#include <X11/Xutil.h>
+#include "ui/gfx/x/x11_error_tracker.h"
#include "ui/gfx/x/x11_types.h"
gfx::ImageSkia GetWindowIcon(content::DesktopMediaID id) {
@@ -20,10 +21,12 @@ gfx::ImageSkia GetWindowIcon(content::DesktopMediaID id) {
unsigned long size;
long* data;
+ gfx::X11ErrorTracker error_tracker;
Daniel Erat 2016/08/26 01:50:39 this should probably be in an std::unique_ptr so y
qiangchen 2016/08/26 15:53:46 Done.
int status = XGetWindowProperty(display, id.id, property, 0L, ~0L, False,
AnyPropertyType, &actual_type, &actual_format,
&size, &bytes_after,
reinterpret_cast<unsigned char**>(&data));
+
if (status != Success) {
return gfx::ImageSkia();
}
« no previous file with comments | « chrome/browser/media/window_icon_util_chromeos.cc ('k') | chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698