DBC: Fix more HTTP benchmark bailouts

DBC: Fix more HTTP benchmark bailouts

HttpRequest(IOPerSecond) ~300 -> ~350

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/b49de12f6c982e8e8e85971209b4c2f155cb778f

[zra, 2016-08-22 22:30:14]

Description was changed from

==========
DBC: Fix more HTTP benchmark bailouts
==========

to

==========
DBC: Fix more HTTP benchmark bailouts

HttpRequest(IOPerSecond) ~300 -> ~350
==========

[zra, 2016-08-22 22:31:04]

zra@google.com changed reviewers:
+ fschneider@google.com, rmacnak@google.com

[Florian Schneider, 2016-08-22 22:45:35]

lgtm

https://codereview.chromium.org/2270483002/diff/1/runtime/vm/simulator_dbc.cc
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2270483002/diff/1/runtime/vm/simulator_dbc.cc...
runtime/vm/simulator_dbc.cc:2958: *data =
static_cast<uint8_t>(Smi::Value(RAW_CAST(Smi, FP[rC])));
static_cast needed?

https://codereview.chromium.org/2270483002/diff/1/runtime/vm/simulator_dbc.cc...
runtime/vm/simulator_dbc.cc:2977: array->ptr()->data()[Smi::Value(index)] =
Smi::Value(value);
Other instructions (StoreIndexedUint8) use a static_cast<uint8_t> here. It seems
it's not needed, right? Can you remove it in the other places?

[zra, 2016-08-22 22:57:29]

https://codereview.chromium.org/2270483002/diff/1/runtime/vm/simulator_dbc.cc
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2270483002/diff/1/runtime/vm/simulator_dbc.cc...
runtime/vm/simulator_dbc.cc:2958: *data =
static_cast<uint8_t>(Smi::Value(RAW_CAST(Smi, FP[rC])));
On 2016/08/22 22:45:35, Florian Schneider wrote:
> static_cast needed?

Removed.

https://codereview.chromium.org/2270483002/diff/1/runtime/vm/simulator_dbc.cc...
runtime/vm/simulator_dbc.cc:2977: array->ptr()->data()[Smi::Value(index)] =
Smi::Value(value);
On 2016/08/22 22:45:35, Florian Schneider wrote:
> Other instructions (StoreIndexedUint8) use a static_cast<uint8_t> here. It
seems
> it's not needed, right? Can you remove it in the other places?
> 

Done.

[zra, 2016-08-22 22:57:59]

Description was changed from

==========
DBC: Fix more HTTP benchmark bailouts

HttpRequest(IOPerSecond) ~300 -> ~350
==========

to

==========
DBC: Fix more HTTP benchmark bailouts

HttpRequest(IOPerSecond) ~300 -> ~350

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b49de12f6c982e8e8e85971209b4c2f155cb778f
==========

[zra, 2016-08-22 22:58:01]

Committed patchset #2 (id:20001) manually as
b49de12f6c982e8e8e85971209b4c2f155cb778f (presubmit successful).