Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2270463003: Turn on enforce-in-pdf Clang plugin flag. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on enforce-in-pdf Clang plugin flag. Fix remaining errors in pdf/ and fix some nits. Committed: https://crrev.com/fa6edbc76ee6bac01443dd1c49c5b6fd60c4a620 Cr-Commit-Position: refs/heads/master@{#413689}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : rebase #

Patch Set 4 : Fix win clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -49 lines) Patch
M build/config/clang/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/pdf/pdf_extension_test.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M pdf/paint_aggregator.h View 2 chunks +1 line, -1 line 0 comments Download
M pdf/paint_aggregator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M pdf/paint_manager.h View 3 chunks +9 lines, -7 lines 0 comments Download
M pdf/paint_manager.cc View 5 chunks +19 lines, -10 lines 0 comments Download
M pdf/pdf_engine.h View 1 2 3 1 chunk +3 lines, -6 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 2 3 3 chunks +25 lines, -0 lines 0 comments Download
M pdf/pdfium/pdfium_page.h View 2 chunks +2 lines, -0 lines 0 comments Download
M pdf/pdfium/pdfium_page.cc View 8 chunks +17 lines, -16 lines 0 comments Download
M pdf/pdfium/pdfium_range.h View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/pdfium/pdfium_range.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
Lei Zhang
4 years, 4 months ago (2016-08-23 00:25:10 UTC) #5
Nico
Lgtm I don't get why people prefer `= default` over `{}`, but hey :-)
4 years, 4 months ago (2016-08-23 00:49:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270463003/60001
4 years, 4 months ago (2016-08-23 08:02:49 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-23 08:07:18 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 08:09:20 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fa6edbc76ee6bac01443dd1c49c5b6fd60c4a620
Cr-Commit-Position: refs/heads/master@{#413689}

Powered by Google App Engine
This is Rietveld 408576698