chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java - Issue 2270443002: Set minimum line number on snippets in narrow layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java

Issue 2270443002: Set minimum line number on snippets in narrow layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java ('k') | chrome/test/data/android/render_tests/ArticleSnippetsTest.long_minimal_snippet_narrow.Nexus_5.port.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java

diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java

index 4daa760da0b4340b0d4c635cdec5a52e2b1e192b..36d4c462f989b071070463ff5bf95803f26a84ba 100644

--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java

+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java

@@ -96,7 +96,7 @@ public class RenderUtils {

File goldenFile = createPath(mGoldenFolder, imagename);

ComparisonResult result = compareBmpToGolden(bitmap, goldenFile);

- if (REPORT_ONLY_DO_NOT_FAIL) {

+ if (REPORT_ONLY_DO_NOT_FAIL && !isGenerateMode()) {

Log.d(TAG, "Image comparison for %s: %s", id, result.name());

return;

}