content/port/browser/render_widget_host_view_port.h - Issue 227043012: mac: History swiping doesn't work right with iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/port/browser/render_widget_host_view_port.h

Issue 227043012: mac: History swiping doesn't work right with iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comment from avi. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac_unittest.mm ('k') | content/public/browser/render_widget_host_view_mac_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/port/browser/render_widget_host_view_port.h

diff --git a/content/port/browser/render_widget_host_view_port.h b/content/port/browser/render_widget_host_view_port.h

index 528ac864e92ad70d72b5464b9e92921450ce8d6e..eaebd1a4a5e235fc24b08fa3c82b35ca65e02008 100644

--- a/content/port/browser/render_widget_host_view_port.h

+++ b/content/port/browser/render_widget_host_view_port.h

@@ -288,8 +288,12 @@ class CONTENT_EXPORT RenderWidgetHostViewPort : public RenderWidgetHostView,

virtual void SetScrollOffsetPinning(

bool is_pinned_to_left, bool is_pinned_to_right) = 0;

- // Called when a mousewheel event was not processed by the renderer.

- virtual void UnhandledWheelEvent(const blink::WebMouseWheelEvent& event) = 0;

+ // When a wheel event is first received, it is sent to the renderer. This

+ // method is invoked once the renderer, and |delegate_| have been given a

+ // chance to process the wheel event. |consumed| indicates whether either

+ // chose to process the |event|. At most one entity should consume an event.

+ virtual void HandledWheelEvent(const blink::WebMouseWheelEvent& event,

+ bool consumed) = 0;

// Called prior to forwarding input event messages to the renderer, giving

// the view a chance to perform in-process event filtering or processing.