Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 227043012: mac: History swiping doesn't work right with iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to comment from avi. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 997e63d3ade77cb0465cc26067724d271a22dad0..5dffd123e1333e6ddaebc5d3e37295243367b2da 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -143,9 +143,7 @@ static float ScaleFactorForView(NSView* view) {
+ (BOOL)shouldAutohideCursorForEvent:(NSEvent*)event;
- (id)initWithRenderWidgetHostViewMac:(RenderWidgetHostViewMac*)r;
-- (void)gotUnhandledWheelEvent;
-- (void)scrollOffsetPinnedToLeft:(BOOL)left toRight:(BOOL)right;
-- (void)setHasHorizontalScrollbar:(BOOL)has_horizontal_scrollbar;
+- (void)gotWheelEventConsumed:(BOOL)consumed;
- (void)keyEvent:(NSEvent*)theEvent wasKeyEquivalent:(BOOL)equiv;
- (void)windowDidChangeBackingProperties:(NSNotification*)notification;
- (void)windowChangedGlobalFrame:(NSNotification*)notification;
@@ -1862,13 +1860,10 @@ gfx::GLSurfaceHandle RenderWidgetHostViewMac::GetCompositingSurface() {
void RenderWidgetHostViewMac::SetHasHorizontalScrollbar(
bool has_horizontal_scrollbar) {
- [cocoa_view_ setHasHorizontalScrollbar:has_horizontal_scrollbar];
}
void RenderWidgetHostViewMac::SetScrollOffsetPinning(
bool is_pinned_to_left, bool is_pinned_to_right) {
- [cocoa_view_ scrollOffsetPinnedToLeft:is_pinned_to_left
- toRight:is_pinned_to_right];
}
bool RenderWidgetHostViewMac::LockMouse() {
@@ -1900,12 +1895,11 @@ void RenderWidgetHostViewMac::UnlockMouse() {
render_widget_host_->LostMouseLock();
}
-void RenderWidgetHostViewMac::UnhandledWheelEvent(
- const blink::WebMouseWheelEvent& event) {
- // Only record a wheel event as unhandled if JavaScript handlers got a chance
- // to see it (no-op wheel events are ignored by the event dispatcher)
+void RenderWidgetHostViewMac::HandledWheelEvent(
+ const blink::WebMouseWheelEvent& event,
+ bool consumed) {
if (event.deltaX || event.deltaY)
- [cocoa_view_ gotUnhandledWheelEvent];
+ [cocoa_view_ gotWheelEventConsumed:consumed];
}
bool RenderWidgetHostViewMac::Send(IPC::Message* message) {
@@ -2364,28 +2358,8 @@ SkBitmap::Config RenderWidgetHostViewMac::PreferredReadbackFormat() {
}
}
-- (void)gotUnhandledWheelEvent {
- if (responderDelegate_ &&
- [responderDelegate_
- respondsToSelector:@selector(gotUnhandledWheelEvent)]) {
- [responderDelegate_ gotUnhandledWheelEvent];
- }
-}
-
-- (void)scrollOffsetPinnedToLeft:(BOOL)left toRight:(BOOL)right {
- if (responderDelegate_ &&
- [responderDelegate_
- respondsToSelector:@selector(scrollOffsetPinnedToLeft:toRight:)]) {
- [responderDelegate_ scrollOffsetPinnedToLeft:left toRight:right];
- }
-}
-
-- (void)setHasHorizontalScrollbar:(BOOL)has_horizontal_scrollbar {
- if (responderDelegate_ &&
- [responderDelegate_
- respondsToSelector:@selector(setHasHorizontalScrollbar:)]) {
- [responderDelegate_ setHasHorizontalScrollbar:has_horizontal_scrollbar];
- }
+- (void)gotWheelEventConsumed:(BOOL)consumed {
+ [responderDelegate_ gotWheelEventConsumed:consumed];
}
- (BOOL)respondsToSelector:(SEL)selector {

Powered by Google App Engine
This is Rietveld 408576698