content/browser/renderer_host/render_widget_host_view_base.cc - Issue 227043012: mac: History swiping doesn't work right with iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 227043012: mac: History swiping doesn't work right with iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Logic for history swiping should not depend on the "pinned" property. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | content/public/browser/render_widget_host_view_mac_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc

index 2e9e43e7d0c763919b13544cd76de984a254d6d0..4ce7eac22fe86203b6b363a8d357ce28b133bdbd 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.cc

+++ b/content/browser/renderer_host/render_widget_host_view_base.cc

@@ -453,8 +453,9 @@ bool RenderWidgetHostViewBase::IsMouseLocked() {

return mouse_locked_;

}

-void RenderWidgetHostViewBase::UnhandledWheelEvent(

- const blink::WebMouseWheelEvent& event) {

+void RenderWidgetHostViewBase::HandledWheelEvent(

+ const blink::WebMouseWheelEvent& event,

+ bool consumed) {

// Most implementations don't need to do anything here.

}