Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: chrome/browser/translate/translate_tab_helper.cc

Issue 227043005: Eliminate TranslateManager listening to //chrome-level notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_tab_helper.cc
diff --git a/chrome/browser/translate/translate_tab_helper.cc b/chrome/browser/translate/translate_tab_helper.cc
index be6b66300b8e54a1c2dd678581236d17d448a609..7762c04789d72b9ff2bbc4a2cb4c970d42cc707a 100644
--- a/chrome/browser/translate/translate_tab_helper.cc
+++ b/chrome/browser/translate/translate_tab_helper.cc
@@ -316,6 +316,9 @@ void TranslateTabHelper::OnLanguageDetermined(
translate_driver_.GetLanguageState().LanguageDetermined(
details.adopted_language, page_needs_translation);
+ if (web_contents())
+ translate_manager_->InitiateTranslation(details.adopted_language);
+
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_TAB_LANGUAGE_DETERMINED,
content::Source<content::WebContents>(web_contents()),
@@ -327,8 +330,9 @@ void TranslateTabHelper::OnPageTranslated(int32 page_id,
const std::string& translated_lang,
TranslateErrors::Type error_type) {
DCHECK(web_contents());
- translate_driver_.GetLanguageState().SetCurrentLanguage(translated_lang);
- translate_driver_.GetLanguageState().set_translation_pending(false);
+ translate_manager_->PageTranslated(
+ original_lang, translated_lang, error_type);
+
PageTranslatedDetails details;
details.source_language = original_lang;
details.target_language = translated_lang;

Powered by Google App Engine
This is Rietveld 408576698