Eliminate TranslateManager listening to //chrome-level notifications.

Eliminate TranslateManager listening to //chrome-level notifications.

The TAB_LANGUAGE_DETERMINED and PAGE_TRANSLATED notifications are sent by
TranslateTabHelper on receiving //chrome-level IPC from the renderer. This CL
exposes new public APIs on TranslateManager and has TranslateTabHelper call
these APIs on receiving the IPC instead of TranslateManager listen for the
notifications that TranslateTabHelper is sending.

BUG=359998
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262357

[droger, 2014-04-07 08:38:08]

It seems to me that this belong to the driver rather than the embedder.

I see that it would not be trivial to put this code in the driver now, because
of deps issues, and that it will be easier to do when TranslateManaher is moved.

Is this a first step to unblock componentization of TranslateManager, or did I
miss something?

[blundell, 2014-04-07 09:00:43]

On 2014/04/07 08:38:08, droger wrote:
> It seems to me that this belong to the driver rather than the embedder.
> 
> I see that it would not be trivial to put this code in the driver now, because
> of deps issues, and that it will be easier to do when TranslateManaher is
moved.
> 
> Is this a first step to unblock componentization of TranslateManager, or did I
> miss something?

The IPC that TranslateTabHelper listens for in order to initiate these flows is
currently sent from //chrome/browser/renderer/translate_helper.cc. It's
architecturally incorrect for the component to listen for IPC that is sent from
the embedder, so until or unless translate_helper.cc is componentized, this code
should stay in the browser-side embedder as well.

[droger, 2014-04-07 09:09:54]

lgtm

https://codereview.chromium.org/227043005/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_manager.cc (right):

https://codereview.chromium.org/227043005/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_manager.cc:200: // Short-circuit out if not
in a state where initiating translation makes
Nit: maybe keep the comment about this being called multiple times.

[blundell, 2014-04-08 05:24:38]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-04-08 05:25:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/227043005/20001

[blundell, 2014-04-08 05:25:22]

https://codereview.chromium.org/227043005/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_manager.cc (right):

https://codereview.chromium.org/227043005/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_manager.cc:200: // Short-circuit out if not
in a state where initiating translation makes
On 2014/04/07 09:09:54, droger wrote:
> Nit: maybe keep the comment about this being called multiple times.

Done.

[commit-bot: I haz the power, 2014-04-08 08:53:40]

Change committed as 262357