Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2270413003: [CacheStorage] Don't store open caches in Blink (Closed)

Created:
4 years, 3 months ago by jkarlin
Modified:
4 years, 3 months ago
Reviewers:
jsbell
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CacheStorage] Don't store open caches in Blink Blink objects were storing cache objects so that they could be returned quickly on subsequent open calls. This is problematic as there can be many contexts (different windows, workers, service workers, and dev tools) opening/deleting caches. If one of them deletes the cache then all of the others need to be invalidated. Rather than synchronize the various contexts, for now just remove the stored caches from Blink. BUG=639034 Committed: https://crrev.com/db792ded02006fe0e9b4230c1b904c0560302007 Cr-Commit-Position: refs/heads/master@{#414147}

Patch Set 1 #

Messages

Total messages: 15 (9 generated)
jkarlin
jsbell@ PTAL at everything jochen@ PTAL for owners Thanks!
4 years, 3 months ago (2016-08-24 19:03:45 UTC) #3
jkarlin
-r jochen as jsbell@ is an owner of the directory in question.
4 years, 3 months ago (2016-08-24 19:04:37 UTC) #7
jsbell
lgtm
4 years, 3 months ago (2016-08-24 19:24:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270413003/1
4 years, 3 months ago (2016-08-24 21:06:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-24 21:15:59 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 21:19:52 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db792ded02006fe0e9b4230c1b904c0560302007
Cr-Commit-Position: refs/heads/master@{#414147}

Powered by Google App Engine
This is Rietveld 408576698