Add relative path to test when creating generated multitest directory

Add relative path to test when creating generated multitest directory

BUG=https://github.com/dart-lang/sdk/issues/27139
R=kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/fda21e2b9a77e9b450d245cac9fdc5168d405122

[Bill Hesse, 2016-08-24 11:37:14]

whesse@google.com changed reviewers:
+ kustermann@google.com

[kustermann, 2016-08-24 12:09:00]

lgtm

https://codereview.chromium.org/2270413002/diff/20001/tools/testing/dart/mult...
File tools/testing/dart/multitest.dart (right):

https://codereview.chromium.org/2270413002/diff/20001/tools/testing/dart/mult...
tools/testing/dart/multitest.dart:307: Path CreateMultitestDirectory(String
outputDir, Path suiteDir, Path sourceDir) {
CreateM... -> createM...

https://codereview.chromium.org/2270413002/diff/20001/tools/testing/dart/mult...
tools/testing/dart/multitest.dart:310:
.append(suiteNameFromPath(suiteDir)).join(relative);
Don't we have some TestUtils.* helpers for generating test paths?

[Bill Hesse, 2016-08-24 12:16:27]

https://codereview.chromium.org/2270413002/diff/20001/tools/testing/dart/mult...
File tools/testing/dart/multitest.dart (right):

https://codereview.chromium.org/2270413002/diff/20001/tools/testing/dart/mult...
tools/testing/dart/multitest.dart:307: Path CreateMultitestDirectory(String
outputDir, Path suiteDir, Path sourceDir) {
On 2016/08/24 12:09:00, kustermann wrote:
> CreateM... -> createM...

Done.

https://codereview.chromium.org/2270413002/diff/20001/tools/testing/dart/mult...
tools/testing/dart/multitest.dart:310:
.append(suiteNameFromPath(suiteDir)).join(relative);
On 2016/08/24 12:09:00, kustermann wrote:
> Don't we have some TestUtils.* helpers for generating test paths?

Those are for generating the directories for compiler output, like dart2js
output.  They apply on top of these multitests, and multitest paths, and make
new directories based on the paths created here.  So they are two orthogonal
layers of generated_test creation.

[Bill Hesse, 2016-08-24 12:16:27]

Description was changed from

==========
Add relative path to test when creating generated multitest directory

BUG=https://github.com/dart-lang/sdk/issues/27139
==========

to

==========
Add relative path to test when creating generated multitest directory

BUG=https://github.com/dart-lang/sdk/issues/27139
R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fda21e2b9a77e9b450d245cac9fdc5168d405122
==========

[Bill Hesse, 2016-08-24 12:16:29]

Committed patchset #3 (id:40001) manually as
fda21e2b9a77e9b450d245cac9fdc5168d405122 (presubmit successful).