Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2270383002: clean up encrypted-media tests (Closed)

Created:
4 years, 4 months ago by Srirama
Modified:
4 years, 4 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clean up encrypted-media tests Removed unnecessary markup (<div id="log">). Replaced getElementById with querySelector. Removed unnecessary "id" and "controls" attributes. Committed: https://crrev.com/5b261b31c00483ce80be18827caa1f3806bfab1e Cr-Commit-Position: refs/heads/master@{#414045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -67 lines) Patch
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-async-creation-with-gc.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-async-setcert-with-gc.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-check-init-data-type.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-clear-key-invalid-license.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-clearkey-update-non-ascii-input.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-events.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-generate-request-disallowed-input.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-keystatuses.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-keys.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-sessions.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-updates.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-reference.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-release.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-release-noreference.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-multiple-mediakeys.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-not-callable-after-createsession.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-onencrypted.html View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-playback-encrypted-and-clear-sources.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-after-src.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-before-src.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-playback-two-videos.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-reset-src-after-setmediakeys.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-session-closed-event.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-setmediakeys.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-setmediakeys-again-after-playback.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-setmediakeys-again-after-resetting-src.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-setmediakeys-at-same-time.html View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-setmediakeys-multiple-times-with-different-mediakeys.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-setmediakeys-multiple-times-with-the-same-mediakeys.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-setmediakeys-to-multiple-video-elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-unique-origin.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-update-disallowed-input.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-waiting-for-a-key.html View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Srirama
PTAL
4 years, 4 months ago (2016-08-24 06:18:43 UTC) #4
fs
lgtm
4 years, 4 months ago (2016-08-24 09:07:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270383002/1
4 years, 4 months ago (2016-08-24 10:19:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 11:45:19 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 11:47:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b261b31c00483ce80be18827caa1f3806bfab1e
Cr-Commit-Position: refs/heads/master@{#414045}

Powered by Google App Engine
This is Rietveld 408576698