Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2270373002:
Remove stale comments for blink::decodeURLEscapeSequences() (Closed)
|
Created:
4 years, 4 months ago by tyoshino (SeeGerritForStatus) Modified:
4 years, 3 months ago Reviewers:
brettw CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove stale comments for blink::decodeURLEscapeSequences()
There are several comments and FIXMEs about concern about NULL
unescaping.
The FIXMEs have been there since the commit for upstreaming
KURLGoogle.cpp which is
http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708.
But the commit
http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already
removed the special care for NULL character. The internal bug b/1350291
was just mentioning WebKit bug 20559.
We still have a warning comment about brettw@'s concern in KURL.h, so,
clean up the others.
As a bonus, this CL adds a test to check that the method decodes UTF-8.
R=brettw
BUG=none
Committed: https://crrev.com/da51acae83242fed9fe954e898893430430a4777
Cr-Commit-Position: refs/heads/master@{#414286}
Patch Set 1 #Patch Set 2 : a #
Messages
Total messages: 19 (14 generated)
Description was changed from ========== - Remove stale FIXMEs about concern about NULL unescaping. This FIXME was there since the commit for upstreaming KURLGoogle.cpp which is 1730ee062f4e55666b1bbf3e777443e508c60708. But the commit 2af27873fe7c1fb7b4ca85d24b023e9c0a533218 has already removed the special care for NULL character. BUG= ========== to ========== - Remove stale comments and FIXMEs about concern about NULL unescaping. This FIXME was there since the commit for upstreaming KURLGoogle.cpp which is 1730ee062f4e55666b1bbf3e777443e508c60708. But the commit 2af27873fe7c1fb7b4ca85d24b023e9c0a533218 has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. BUG= ==========
Description was changed from ========== - Remove stale comments and FIXMEs about concern about NULL unescaping. This FIXME was there since the commit for upstreaming KURLGoogle.cpp which is 1730ee062f4e55666b1bbf3e777443e508c60708. But the commit 2af27873fe7c1fb7b4ca85d24b023e9c0a533218 has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. BUG= ========== to ========== - Remove stale comments and FIXMEs about concern about NULL unescaping. This FIXME was there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. BUG= ==========
Description was changed from ========== - Remove stale comments and FIXMEs about concern about NULL unescaping. This FIXME was there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. BUG= ========== to ========== Remove stale comments for blink::decodeURLEscapeSequences() There are several comments and FIXMEs about concern about NULL unescaping. The FIXMEs have been there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. We still have a warning comment about brettw@'s concern in KURL.h, so, clean up the others. BUG=none ==========
Description was changed from ========== Remove stale comments for blink::decodeURLEscapeSequences() There are several comments and FIXMEs about concern about NULL unescaping. The FIXMEs have been there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. We still have a warning comment about brettw@'s concern in KURL.h, so, clean up the others. BUG=none ========== to ========== Remove stale comments for blink::decodeURLEscapeSequences() There are several comments and FIXMEs about concern about NULL unescaping. The FIXMEs have been there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. We still have a warning comment about brettw@'s concern in KURL.h, so, clean up the others. As a bonus, this CL adds a test to check that the method decodes UTF-8. BUG=none ==========
Description was changed from ========== Remove stale comments for blink::decodeURLEscapeSequences() There are several comments and FIXMEs about concern about NULL unescaping. The FIXMEs have been there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. We still have a warning comment about brettw@'s concern in KURL.h, so, clean up the others. As a bonus, this CL adds a test to check that the method decodes UTF-8. BUG=none ========== to ========== Remove stale comments for blink::decodeURLEscapeSequences() There are several comments and FIXMEs about concern about NULL unescaping. The FIXMEs have been there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. We still have a warning comment about brettw@'s concern in KURL.h, so, clean up the others. As a bonus, this CL adds a test to check that the method decodes UTF-8. BUG=none ==========
tyoshino@chromium.org changed reviewers: + brettw@chromium.org
The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
lgtm
Description was changed from ========== Remove stale comments for blink::decodeURLEscapeSequences() There are several comments and FIXMEs about concern about NULL unescaping. The FIXMEs have been there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. We still have a warning comment about brettw@'s concern in KURL.h, so, clean up the others. As a bonus, this CL adds a test to check that the method decodes UTF-8. BUG=none ========== to ========== Remove stale comments for blink::decodeURLEscapeSequences() There are several comments and FIXMEs about concern about NULL unescaping. The FIXMEs have been there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. We still have a warning comment about brettw@'s concern in KURL.h, so, clean up the others. As a bonus, this CL adds a test to check that the method decodes UTF-8. R=brettw BUG=none ==========
The CQ bit was checked by tyoshino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove stale comments for blink::decodeURLEscapeSequences() There are several comments and FIXMEs about concern about NULL unescaping. The FIXMEs have been there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. We still have a warning comment about brettw@'s concern in KURL.h, so, clean up the others. As a bonus, this CL adds a test to check that the method decodes UTF-8. R=brettw BUG=none ========== to ========== Remove stale comments for blink::decodeURLEscapeSequences() There are several comments and FIXMEs about concern about NULL unescaping. The FIXMEs have been there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. We still have a warning comment about brettw@'s concern in KURL.h, so, clean up the others. As a bonus, this CL adds a test to check that the method decodes UTF-8. R=brettw BUG=none ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove stale comments for blink::decodeURLEscapeSequences() There are several comments and FIXMEs about concern about NULL unescaping. The FIXMEs have been there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. We still have a warning comment about brettw@'s concern in KURL.h, so, clean up the others. As a bonus, this CL adds a test to check that the method decodes UTF-8. R=brettw BUG=none ========== to ========== Remove stale comments for blink::decodeURLEscapeSequences() There are several comments and FIXMEs about concern about NULL unescaping. The FIXMEs have been there since the commit for upstreaming KURLGoogle.cpp which is http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708. But the commit http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already removed the special care for NULL character. The internal bug b/1350291 was just mentioning WebKit bug 20559. We still have a warning comment about brettw@'s concern in KURL.h, so, clean up the others. As a bonus, this CL adds a test to check that the method decodes UTF-8. R=brettw BUG=none Committed: https://crrev.com/da51acae83242fed9fe954e898893430430a4777 Cr-Commit-Position: refs/heads/master@{#414286} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/da51acae83242fed9fe954e898893430430a4777 Cr-Commit-Position: refs/heads/master@{#414286} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
