Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled. (Closed)
Patch Set: Now owned by BlimpContentsViewAndroid and also implemented touch and sizing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index e914ba5da5ff5d7812c01579ecc70b25ee13ad2b..5a17ad8397a54cdc923448ff02b7fa77dca790a8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -1502,7 +1502,8 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
if (isBlimpTab() && getBlimpContents() == null) {
Profile profile = Profile.getLastUsedProfile();
if (mIncognito) profile = profile.getOffTheRecordProfile();
- mBlimpContents = nativeInitBlimpContents(mNativeTabAndroid, profile);
+ mBlimpContents = nativeInitBlimpContents(
+ mNativeTabAndroid, profile, mWindowAndroid.getNativePointer());
getBlimpContents().addObserver(new TabBlimpContentsObserver(this));
}
@@ -3312,7 +3313,8 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
private native void nativeInitWebContents(long nativeTabAndroid, boolean incognito,
WebContents webContents, TabWebContentsDelegateAndroid delegate,
ContextMenuPopulator contextMenuPopulator);
- private native BlimpContents nativeInitBlimpContents(long nativeTabAndroid, Profile profile);
+ private native BlimpContents nativeInitBlimpContents(
+ long nativeTabAndroid, Profile profile, long windowAndroidPtr);
private native void nativeUpdateDelegates(long nativeTabAndroid,
TabWebContentsDelegateAndroid delegate, ContextMenuPopulator contextMenuPopulator);
private native void nativeDestroyWebContents(long nativeTabAndroid, boolean deleteNative);

Powered by Google App Engine
This is Rietveld 408576698