Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: blimp/client/core/contents/blimp_contents_view_android.cc

Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled. (Closed)
Patch Set: addressed nit, renamed CreateForTesting and piped through touch handling Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_contents_view_android.cc
diff --git a/blimp/client/core/contents/blimp_contents_view_android.cc b/blimp/client/core/contents/blimp_contents_view_android.cc
index 2ade9c31ada69c2376e62df5291e1e672b17b75e..031023fae2facc390258ee235aa30b669a417504 100644
--- a/blimp/client/core/contents/blimp_contents_view_android.cc
+++ b/blimp/client/core/contents/blimp_contents_view_android.cc
@@ -6,7 +6,9 @@
#include "base/memory/ptr_util.h"
#include "blimp/client/core/contents/android/blimp_contents_impl_android.h"
+#include "blimp/client/core/contents/android/blimp_view.h"
#include "cc/layers/layer.h"
+#include "ui/android/window_android.h"
namespace blimp {
namespace client {
@@ -15,21 +17,28 @@ namespace client {
std::unique_ptr<BlimpContentsView> BlimpContentsView::Create(
BlimpContentsImpl* blimp_contents,
scoped_refptr<cc::Layer> contents_layer) {
- return base::MakeUnique<BlimpContentsViewAndroid>(
- blimp_contents->GetBlimpContentsImplAndroid(), contents_layer);
+ return base::MakeUnique<BlimpContentsViewAndroid>(blimp_contents,
+ contents_layer);
}
BlimpContentsViewAndroid::BlimpContentsViewAndroid(
- BlimpContentsImplAndroid* blimp_contents,
+ BlimpContentsImpl* blimp_contents,
scoped_refptr<cc::Layer> contents_layer) {
- // TODO(khushalsagar): Get the ViewAndroidDelegate from java after it has a
- // BlimpView. Also get the WindowAndroid so this view can add itself as a
- // child to it.
- view_.SetLayer(contents_layer);
+ blimp_view_ = base::MakeUnique<BlimpView>(blimp_contents);
+ view_ = base::MakeUnique<ui::ViewAndroid>(
+ blimp_view_->CreateViewAndroidDelegate());
+ view_->SetLayer(contents_layer);
+ blimp_contents->GetNativeWindow()->AddChild(view_.get());
}
+BlimpContentsViewAndroid::~BlimpContentsViewAndroid() = default;
+
gfx::NativeView BlimpContentsViewAndroid::GetNativeView() {
- return &view_;
+ return view_.get();
+}
+
+BlimpView* BlimpContentsViewAndroid::GetBlimpView() {
+ return blimp_view_.get();
}
} // namespace client
« no previous file with comments | « blimp/client/core/contents/blimp_contents_view_android.h ('k') | blimp/client/core/dummy_blimp_client_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698