Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: components/test_runner/spell_check_client.h

Issue 2270293003: Add a switch to TestRunner to enable/disable mock spell checker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebaselined tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/spell_check_client.h
diff --git a/components/test_runner/spell_check_client.h b/components/test_runner/spell_check_client.h
index f9f23cb1191e1dabcbd4e5e71bd254bd997df65b..4561016cb6506f19ca15c6e59c775778201a9b40 100644
--- a/components/test_runner/spell_check_client.h
+++ b/components/test_runner/spell_check_client.h
@@ -30,6 +30,7 @@ class SpellCheckClient : public blink::WebSpellCheckClient {
virtual ~SpellCheckClient();
void SetDelegate(WebTestDelegate* delegate);
+ void SetEnabled(bool enabled);
// blink::WebSpellCheckClient implementation.
void spellCheck(
@@ -47,6 +48,10 @@ class SpellCheckClient : public blink::WebSpellCheckClient {
private:
void FinishLastTextCheck();
+ // Do not perform any checking when |enabled_ == false|.
+ // Tests related to spell checking should enable it manually.
+ bool enabled_;
yosin_UTC9 2016/08/24 08:00:38 s/enabled_;/enabled_ = false;/
Xiaocheng 2016/08/24 08:28:23 Done.
+
// The mock spellchecker used in spellCheck().
MockSpellCheck spell_check_;
« no previous file with comments | « no previous file | components/test_runner/spell_check_client.cc » ('j') | components/test_runner/spell_check_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698