Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2270283003: [Remoting Android] Explicitly define title text size in sp (Closed)

Created:
4 years, 4 months ago by Yuwei
Modified:
4 years, 4 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Explicitly define title text size in sp For some reason the toolbar title text size is not font scale dependent. Increasing the font size in Accessibility->Font Size will change the text size everywhere except the app title. This CL fixes this problem by defining the title text size explicitly in sp. BUG=635584 Committed: https://crrev.com/310fd4b25b1924238d549d539fc0667ccf75da51 Cr-Commit-Position: refs/heads/master@{#414230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M remoting/android/java/res/values-v17/styles.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuwei
ptal
4 years, 4 months ago (2016-08-24 22:24:43 UTC) #2
joedow
lgtm
4 years, 4 months ago (2016-08-24 22:36:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270283003/1
4 years, 4 months ago (2016-08-24 22:39:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 00:46:16 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 00:48:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/310fd4b25b1924238d549d539fc0667ccf75da51
Cr-Commit-Position: refs/heads/master@{#414230}

Powered by Google App Engine
This is Rietveld 408576698