Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2270273002: cc : Add OnFilterAnimated to effect tree (Closed)

Created:
4 years, 3 months ago by jaydasika
Modified:
4 years, 3 months ago
Reviewers:
ajuma, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org, sunxd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Add OnFilterAnimated to effect tree And use it to update filter animations directly instead of routing the updates through layers. BUG=638297 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/db849fce1c4187357e3051e4860bf206ccaec0bb Cr-Commit-Position: refs/heads/master@{#414239}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -35 lines) Patch
M cc/layers/layer_impl.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 1 2 3 chunks +23 lines, -8 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M cc/trees/property_tree.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/property_tree.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
jaydasika
PTAL https://codereview.chromium.org/2270273002/diff/20001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2270273002/diff/20001/cc/trees/layer_tree_host_impl.cc#newcode3921 cc/trees/layer_tree_host_impl.cc:3921: filters, layer->effect_tree_index(), tree); Will change this to use ...
4 years, 3 months ago (2016-08-24 00:06:02 UTC) #4
ajuma
lgtm
4 years, 3 months ago (2016-08-24 14:36:09 UTC) #10
jaydasika
https://codereview.chromium.org/2270273002/diff/20001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2270273002/diff/20001/cc/trees/layer_tree_host_impl.cc#newcode3921 cc/trees/layer_tree_host_impl.cc:3921: filters, layer->effect_tree_index(), tree); On 2016/08/24 00:06:01, jaydasika wrote: > ...
4 years, 3 months ago (2016-08-24 22:08:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270273002/60001
4 years, 3 months ago (2016-08-24 22:09:55 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/268087)
4 years, 3 months ago (2016-08-24 23:48:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270273002/60001
4 years, 3 months ago (2016-08-24 23:49:49 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-25 01:04:49 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 01:06:30 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/db849fce1c4187357e3051e4860bf206ccaec0bb
Cr-Commit-Position: refs/heads/master@{#414239}

Powered by Google App Engine
This is Rietveld 408576698