Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2270223002: Disallow 'yield' in async arrow parameter lists inside generators (Closed)

Created:
4 years, 4 months ago by adamk
Modified:
4 years, 4 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disallow 'yield' in async arrow parameter lists inside generators R=littledan@chromium.org BUG=v8:4483 Committed: https://crrev.com/9a558c5f4aa11cba6953901fcab56510786a2c8c Cr-Commit-Position: refs/heads/master@{#38846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/parsing/parser-base.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
adamk
4 years, 4 months ago (2016-08-23 21:53:10 UTC) #1
Dan Ehrenberg
lgtm
4 years, 4 months ago (2016-08-23 22:09:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270223002/1
4 years, 4 months ago (2016-08-23 22:12:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 22:17:36 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 22:17:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a558c5f4aa11cba6953901fcab56510786a2c8c
Cr-Commit-Position: refs/heads/master@{#38846}

Powered by Google App Engine
This is Rietveld 408576698