Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2270213002: Annotate ScopeType with uint8_t (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Annotate ScopeType with uint8_t BUG=v8:5209 Committed: https://crrev.com/920f5fcd1e7c2483220513a8cd2930daf6b143cc Cr-Commit-Position: refs/heads/master@{#38853}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/globals.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-23 21:51:57 UTC) #2
adamk
lgtm
4 years, 4 months ago (2016-08-23 22:05:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270213002/20001
4 years, 4 months ago (2016-08-24 04:49:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 08:49:47 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 08:50:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/920f5fcd1e7c2483220513a8cd2930daf6b143cc
Cr-Commit-Position: refs/heads/master@{#38853}

Powered by Google App Engine
This is Rietveld 408576698