Fix leak of sequenced worker pool in unit tests when service_ is replaced.

net/ssl/server_bound_cert_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ssl/server_bound_cert_service.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 511 matching lines @@
   // Asynchronous completion with no certs in the store.
   std::string private_key_info, der_cert;
   EXPECT_EQ(0, service_->cert_count());
   error = service_->GetDomainBoundCert(
       host, &private_key_info, &der_cert, callback.callback(), &request_handle);
   EXPECT_EQ(ERR_IO_PENDING, error);
   EXPECT_TRUE(request_handle.is_active());
 
   mock_store->CallGetServerBoundCertCallbackWithResult(
       ERR_FILE_NOT_FOUND, base::Time(), std::string(), std::string());
+  // Wait for any posted ServerBoundCertServiceWorkers to finish.
+  // (By calling CallGetServerBoundCertCallbackWithResult, callbacks are
+  // called directly, short-circuiting ServerBoundCertService's usual
+  // bookkeeping.)
+  sequenced_worker_pool_->FlushForTesting();
+  base::MessageLoop::current()->RunUntilIdle();

[Ryan Sleevi, 2013/08/08 23:18:46]

Consider updating the comments to be more descriptive on why both calls are
necessary. See the other tests here.

[juanlang, 2013/08/08 23:51:08]

Done, I think. The rationale is different, and unlike the other tests, I don't
need to wait to ensure correct results. I also moved the calls to the end of the
tests to make it clearer that they're not necessary for correctness, merely for
good memory behavior.

 
   error = callback.WaitForResult();
   EXPECT_EQ(OK, error);
   EXPECT_EQ(1, service_->cert_count());
   EXPECT_FALSE(private_key_info.empty());
   EXPECT_FALSE(der_cert.empty());
   EXPECT_FALSE(request_handle.is_active());
 }
 
 TEST_F(ServerBoundCertServiceTest, AsyncStoreGetOneCertInStore) {
@@ skipping 11 matching lines @@
   // Asynchronous completion with a cert in the store.
   std::string private_key_info, der_cert;
   EXPECT_EQ(0, service_->cert_count());
   error = service_->GetDomainBoundCert(
       host, &private_key_info, &der_cert, callback.callback(), &request_handle);
   EXPECT_EQ(ERR_IO_PENDING, error);
   EXPECT_TRUE(request_handle.is_active());
 
   mock_store->CallGetServerBoundCertCallbackWithResult(
       OK, base::Time(), "ab", "cd");
+  // Wait for any posted ServerBoundCertServiceWorkers to finish.
+  // (By calling CallGetServerBoundCertCallbackWithResult, callbacks are
+  // called directly, short-circuiting ServerBoundCertService's usual
+  // bookkeeping.)
+  sequenced_worker_pool_->FlushForTesting();
+  base::MessageLoop::current()->RunUntilIdle();
 
   error = callback.WaitForResult();
   EXPECT_EQ(OK, error);
   EXPECT_EQ(1, service_->cert_count());
   EXPECT_EQ(1u, service_->requests());
   EXPECT_EQ(1u, service_->cert_store_hits());
   // Because the cert was found in the store, no new workers should have been
   // created.
   EXPECT_EQ(0u, service_->workers_created());
   EXPECT_STREQ("ab", private_key_info.c_str());
   EXPECT_STREQ("cd", der_cert.c_str());
   EXPECT_FALSE(request_handle.is_active());
 }
 
 #endif  // !defined(USE_OPENSSL)
 
 }  // namespace
 
 }  // namespace net