Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2270193003: X87: [turbofan] Add Float32(Max|Min) machine operators. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Add Float32(Max|Min) machine operators. port 2027b0bed15e89583b31a8ea1a53cb85cccffda2 (r38784) original commit message: The new operators are implemented similar to the Float64(Max|Min) which already exist. The purpose of the new operators is the implementation of the F32Max and F32Min instructions in WebAssembly. BUG= Committed: https://crrev.com/909641fd5efe6510e967bacdccf9e353a3941fc8 Cr-Commit-Position: refs/heads/master@{#38857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +72 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-24 02:41:39 UTC) #2
Weiliang
lgtm
4 years, 4 months ago (2016-08-24 07:20:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270193003/1
4 years, 4 months ago (2016-08-24 07:48:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 08:54:12 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 08:54:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/909641fd5efe6510e967bacdccf9e353a3941fc8
Cr-Commit-Position: refs/heads/master@{#38857}

Powered by Google App Engine
This is Rietveld 408576698