Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 2270163002: Delete more document mode specific code. (Closed)

Created:
4 years, 4 months ago by Peter Wen
Modified:
4 years, 3 months ago
Reviewers:
Theresa, gone
CC:
chromium-reviews, noyau+watch_chromium.org, browser-components-watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete more document mode specific code. - Clean-up unused UMA stats. - Remove unreachable code in ChromeTabbedActivity and ChromeApplication. - Remove unnecessary bookmark title setter. - Clean-up incognito code specific to document mode. BUG=612245 Committed: https://crrev.com/0ee82a9e022622d1fc4c35719f9737e54ba60b2f Cr-Commit-Position: refs/heads/master@{#414060}

Patch Set 1 #

Messages

Total messages: 13 (6 generated)
Peter Wen
Hi Theresa, Could you review this clean-up CL? Thanks, Peter
4 years, 4 months ago (2016-08-23 19:52:35 UTC) #3
Theresa
lgtm, but still needs OWNERS approval
4 years, 4 months ago (2016-08-23 20:57:32 UTC) #4
Peter Wen
+dfalcantara@ for OWNERS.
4 years, 4 months ago (2016-08-23 21:15:05 UTC) #6
gone
lgtm
4 years, 4 months ago (2016-08-23 23:13:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270163002/1
4 years, 4 months ago (2016-08-24 12:42:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 13:22:05 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 13:23:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ee82a9e022622d1fc4c35719f9737e54ba60b2f
Cr-Commit-Position: refs/heads/master@{#414060}

Powered by Google App Engine
This is Rietveld 408576698