Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2270153002: Fix typo in ExpressionClassifier cleanup (Closed)

Created:
4 years, 3 months ago by adamk
Modified:
4 years, 3 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix typo in ExpressionClassifier cleanup "ExpressionProductions" was missing the plural. I don't think this changed any behavior, but I'd rather be safe than sorry. Also removed redundant mention of TailCall production. A future patch will attempt to make calls to Accumulate make more sense, in general. R=littledan@chromium.org Committed: https://crrev.com/55a6588dae591e0b3ae6bd4de44eefbbd2639d03 Cr-Commit-Position: refs/heads/master@{#38842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/parsing/parser-base.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
adamk
4 years, 3 months ago (2016-08-23 19:31:02 UTC) #1
Dan Ehrenberg
lgtm
4 years, 3 months ago (2016-08-23 19:31:42 UTC) #4
adamk
Future cleanup will also hopefully get rid of the case where we have two enum ...
4 years, 3 months ago (2016-08-23 19:32:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270153002/1
4 years, 3 months ago (2016-08-23 19:33:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-23 19:57:35 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-23 19:58:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55a6588dae591e0b3ae6bd4de44eefbbd2639d03
Cr-Commit-Position: refs/heads/master@{#38842}

Powered by Google App Engine
This is Rietveld 408576698