Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2270143002: ui/events: Add changed_button_flags_ in ui::PointerEvent. (Closed)

Created:
4 years, 4 months ago by Peng
Modified:
4 years, 3 months ago
Reviewers:
sky, dcheng, piman
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, tdresser+watch_chromium.org, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/events: Add changed_button_flags_ in ui::PointerEvent. BUG=638411 Committed: https://crrev.com/697f32670af01570942253f0347f789de5d38e55 Cr-Commit-Position: refs/heads/master@{#414486}

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Update #

Patch Set 4 : Update #

Patch Set 5 : Fix build errors #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -28 lines) Patch
M content/renderer/mus/compositor_mus_connection_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/tests/window_tree_client_unittest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M services/ui/ws/event_dispatcher.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/event.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/event.cc View 5 chunks +6 lines, -1 line 0 comments Download
M ui/events/event_unittest.cc View 1 3 chunks +13 lines, -10 lines 0 comments Download
M ui/events/mojo/OWNERS View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/events/mojo/event.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/mojo/event_struct_traits.cc View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M ui/events/mojo/struct_traits_unittest.cc View 1 2 3 2 chunks +9 lines, -6 lines 0 comments Download
M ui/views/mus/pointer_watcher_event_router_unittest.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 38 (25 generated)
Peng
Hi Scott, PTAL. Thanks.
4 years, 4 months ago (2016-08-23 19:22:52 UTC) #8
sky
LGTM
4 years, 4 months ago (2016-08-23 22:30:02 UTC) #18
Peng
+dcheng@ for *.mojom Hi Daniel, PTAL. Thanks.
4 years, 4 months ago (2016-08-23 22:34:11 UTC) #20
Peng
piman@chromium.org: Please review changes in //content/* Hi Antoine, PTAL. Thanks.
4 years, 4 months ago (2016-08-23 22:36:05 UTC) #22
piman
lgtm
4 years, 4 months ago (2016-08-23 22:41:58 UTC) #23
dcheng
lgtm
4 years, 4 months ago (2016-08-24 20:24:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270143002/100001
4 years, 4 months ago (2016-08-24 20:32:40 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/57806)
4 years, 4 months ago (2016-08-24 20:39:14 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270143002/120001
4 years, 3 months ago (2016-08-25 14:30:37 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/268748)
4 years, 3 months ago (2016-08-25 17:15:31 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270143002/120001
4 years, 3 months ago (2016-08-25 17:27:41 UTC) #35
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 3 months ago (2016-08-25 18:36:38 UTC) #36
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 18:40:18 UTC) #38
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/697f32670af01570942253f0347f789de5d38e55
Cr-Commit-Position: refs/heads/master@{#414486}

Powered by Google App Engine
This is Rietveld 408576698