Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2270093002: Add CPU measurements to power metric. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 3 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Add CPU measurements to power metric. These metrics provide more granular information about the CPU usage of chrome for performance benchmarks. BUG=640054 Committed: https://crrev.com/03a86b97ad34c5d4934174b3f961d60934855e03 Cr-Commit-Position: refs/heads/master@{#414231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/perf/metrics/power.py View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
erikchen
nednguyen: Please review.
4 years, 4 months ago (2016-08-23 17:37:26 UTC) #3
nednguyen
On 2016/08/23 17:37:26, erikchen wrote: > nednguyen: Please review. I am not sure it worth ...
4 years, 4 months ago (2016-08-23 17:45:54 UTC) #4
erikchen
On 2016/08/23 17:45:54, nednguyen wrote: > On 2016/08/23 17:37:26, erikchen wrote: > > nednguyen: Please ...
4 years, 4 months ago (2016-08-23 17:57:41 UTC) #5
nednguyen
lgtm
4 years, 4 months ago (2016-08-23 19:24:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270093002/1
4 years, 3 months ago (2016-08-25 00:27:11 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 00:50:02 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 00:53:03 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03a86b97ad34c5d4934174b3f961d60934855e03
Cr-Commit-Position: refs/heads/master@{#414231}

Powered by Google App Engine
This is Rietveld 408576698