Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2270083004: Default gclient's GIT_MODE to True (Closed)

Created:
4 years, 4 months ago by agable
Modified:
4 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Default gclient's GIT_MODE to True Also contains some other changes (to the example, and to safesync url) in order for test coverage to remain complete. Will be followed shortly by a wholesale removal of svn support from the gclient module. R=iannucci@chromium.org BUG=640251 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/4b21db06e48e90335a0a1ae5d5b911b960ea0e5a

Patch Set 1 #

Patch Set 2 : A slightly gentler hand with pragmas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -45 lines) Patch
M recipe_modules/gclient/api.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
M recipe_modules/gclient/config.py View 1 6 chunks +12 lines, -12 lines 0 comments Download
M recipe_modules/gclient/example.expected/basic.json View 3 chunks +44 lines, -6 lines 0 comments Download
M recipe_modules/gclient/example.expected/revision.json View 3 chunks +44 lines, -6 lines 0 comments Download
M recipe_modules/gclient/example.expected/tryserver.json View 3 chunks +44 lines, -17 lines 0 comments Download
M recipe_modules/gclient/test_api.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
agable
4 years, 4 months ago (2016-08-23 17:56:09 UTC) #1
iannucci
lgtm, though we need to follow this up with a change to remove GIT_MODE
4 years, 4 months ago (2016-08-23 19:08:51 UTC) #2
iannucci
On 2016/08/23 at 19:08:51, iannucci wrote: > lgtm, though we need to follow this up ...
4 years, 4 months ago (2016-08-23 19:10:10 UTC) #3
agable
I've done all of the downstream changes and now the autoroller should like this. Landing!
4 years, 4 months ago (2016-08-25 03:11:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270083004/20001
4 years, 4 months ago (2016-08-25 03:11:27 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 03:18:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/4b21db06e48e90...

Powered by Google App Engine
This is Rietveld 408576698