Issue 227008: Add touchpad sensitivity setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227008: Add touchpad sensitivity setting. (Closed)

Created:
11 years, 3 months ago by Charlie Lee (do not use)

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add touchpad sensitivity setting. BUG=none TEST=none

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -26 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/settings_contents_view.cc	View		7 chunks	+29 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/touchpad.h	View	1	1 chunk	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/touchpad.cc	View	1	5 chunks	+38 lines, -15 lines	0 comments	Download
M	chrome/browser/options_util.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM with the following changes. http://codereview.chromium.org/227008/diff/4010/5011 File chrome/browser/chromeos/touchpad.cc (right): http://codereview.chromium.org/227008/diff/4010/5011#newcode127 Line 127: // the pressure ...

11 years, 3 months ago (2009-09-23 20:37:32 UTC) #2

Charlie Lee (do not use)

11 years, 3 months ago (2009-09-23 20:48:16 UTC) #3

Thanks. Please land this change for me.

http://codereview.chromium.org/227008/diff/4010/5011
File chrome/browser/chromeos/touchpad.cc (right):

http://codereview.chromium.org/227008/diff/4010/5011#newcode127
Line 127: // the pressure needed for a tap to be register. The range of
FingerHigh goes
On 2009/09/23 20:37:33, sky wrote:
> register-> registered

Done.

http://codereview.chromium.org/227008/diff/4010/5012
File chrome/browser/chromeos/touchpad.h (right):

http://codereview.chromium.org/227008/diff/4010/5012#newcode57
Line 57: // Set tap sensitivity to value stored in preference.
On 2009/09/23 20:37:33, sky wrote:
> preference -> preferences

Done.

Expand Messages | Collapse Messages

Issue 227008: Add touchpad sensitivity setting. (Closed)

Description

Patch Set 1 : '' #

Patch Set 2 : '' #

Messages