Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: ios/chrome/browser/ui/commands/clear_browsing_data_command.mm

Issue 2270063005: Add support for time based deletion of browsing data on iOS (Closed)
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/commands/clear_browsing_data_command.mm
diff --git a/ios/chrome/browser/ui/commands/clear_browsing_data_command.mm b/ios/chrome/browser/ui/commands/clear_browsing_data_command.mm
index 647df9e9b28caccef5cd05c8310c2457f93ccd91..40fe89c0de137887d2c115255f4a1ea553b2b7a2 100644
--- a/ios/chrome/browser/ui/commands/clear_browsing_data_command.mm
+++ b/ios/chrome/browser/ui/commands/clear_browsing_data_command.mm
@@ -11,6 +11,7 @@
@synthesize browserState = _browserState;
@synthesize mask = _mask;
+@synthesize timePeriod = _timePeriod;
- (instancetype)initWithTag:(NSInteger)tag {
NOTREACHED();
@@ -18,12 +19,26 @@
}
- (instancetype)initWithBrowserState:(ios::ChromeBrowserState*)browserState
+ mask:(int)mask
+ timePeriod:(browsing_data::TimePeriod)timePeriod {
+ self = [super initWithTag:IDC_CLEAR_BROWSING_DATA_IOS];
+ if (self) {
+ DCHECK(browserState);
+ _browserState = browserState;
+ _mask = mask;
+ _timePeriod = timePeriod;
+ }
+ return self;
+}
+
+- (instancetype)initWithBrowserState:(ios::ChromeBrowserState*)browserState
mask:(int)mask {
droger 2016/08/30 13:00:48 Should this be implemented by calling the other co
ioanap 2016/08/30 15:08:51 Done.
self = [super initWithTag:IDC_CLEAR_BROWSING_DATA_IOS];
if (self) {
DCHECK(browserState);
_browserState = browserState;
_mask = mask;
+ _timePeriod = browsing_data::ALL_TIME;
}
return self;
}

Powered by Google App Engine
This is Rietveld 408576698