Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2270063004: [Chromoting] Add more logging to Mac install script. (Closed)

Created:
4 years, 4 months ago by garykac
Modified:
4 years, 4 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Add more logging to Mac install script. BUG= Committed: https://crrev.com/d3740acc35a7096f5705c5f28765d5ec1d59c1d1 Cr-Commit-Position: refs/heads/master@{#414174}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add log when restoring _enabled file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M remoting/host/installer/mac/Scripts/keystone_install.sh View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/host/installer/mac/Scripts/remoting_postflight.sh View 1 2 chunks +3 lines, -0 lines 0 comments Download
M remoting/host/installer/mac/Scripts/remoting_preflight.sh View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
garykac
4 years, 4 months ago (2016-08-24 18:07:18 UTC) #2
Jamie
lgtm https://codereview.chromium.org/2270063004/diff/1/remoting/host/installer/mac/Scripts/remoting_postflight.sh File remoting/host/installer/mac/Scripts/remoting_postflight.sh (right): https://codereview.chromium.org/2270063004/diff/1/remoting/host/installer/mac/Scripts/remoting_postflight.sh#newcode63 remoting/host/installer/mac/Scripts/remoting_postflight.sh:63: mv "$ENABLED_FILE_BACKUP" "$ENABLED_FILE" Add a log here.
4 years, 4 months ago (2016-08-24 21:29:16 UTC) #3
garykac
https://codereview.chromium.org/2270063004/diff/1/remoting/host/installer/mac/Scripts/remoting_postflight.sh File remoting/host/installer/mac/Scripts/remoting_postflight.sh (right): https://codereview.chromium.org/2270063004/diff/1/remoting/host/installer/mac/Scripts/remoting_postflight.sh#newcode63 remoting/host/installer/mac/Scripts/remoting_postflight.sh:63: mv "$ENABLED_FILE_BACKUP" "$ENABLED_FILE" On 2016/08/24 21:29:16, Jamie wrote: > ...
4 years, 4 months ago (2016-08-24 21:35:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270063004/20001
4 years, 4 months ago (2016-08-24 21:36:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 22:36:19 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 22:39:59 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d3740acc35a7096f5705c5f28765d5ec1d59c1d1
Cr-Commit-Position: refs/heads/master@{#414174}

Powered by Google App Engine
This is Rietveld 408576698