Issue 227006: Move some more methods from WebViewDelegate to WebViewClient....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227006: Move some more methods from WebViewDelegate to WebViewClient.... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, jam, darin (slow to review), brettw, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move some more methods from WebViewDelegate to WebViewClient. This CL also removes two unnecessary methods on WebViewDelegate: UserMetricsRecordAction and ShowSpellingUI were both never called. R=dglazkov BUG=10033 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26965

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -96 lines)			Patch
M	chrome/renderer/print_web_view_helper.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	3 chunks	+28 lines, -33 lines	0 comments	Download
M	webkit/api/public/WebViewClient.h	View	1 chunk	+14 lines, -5 lines	0 comments	Download
M	webkit/glue/editor_client_impl.cc	View	3 chunks	+14 lines, -23 lines	0 comments	Download
M	webkit/glue/webview_delegate.h	View	2 chunks	+0 lines, -29 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages