third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js - Issue 2270033003: DevTools: include traces when exporting console log via 'Save as'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

Issue 2270033003: DevTools: include traces when exporting console log via 'Save as' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: take out post-lgtm repeat logic Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

index 4f9e5fac6378a60b1fbb3943094af577f7bf932d..65c96e2da4beecded84524a4593ac05a24d1b818 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

@@ -240,6 +240,7 @@ WebInspector.DOMPresentationUtils.buildStackTracePreviewContents = function(targ

{

for (var stackFrame of stackTrace.callFrames) {

var row = createElement("tr");

+ row.createChild("td").textContent = "\n";

row.createChild("td", "function-name").textContent = WebInspector.beautifyFunctionName(stackFrame.functionName);

var link = linkifier.maybeLinkifyConsoleCallFrame(target, stackFrame);

if (link) {

@@ -262,6 +263,7 @@ WebInspector.DOMPresentationUtils.buildStackTracePreviewContents = function(targ

continue;

}

var row = contentElement.createChild("tr");

+ row.createChild("td").textContent = "\n";

row.createChild("td", "stack-preview-async-description").textContent = WebInspector.asyncStackTraceLabel(asyncStackTrace.description);

row.createChild("td");