Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2186)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

Issue 2270033003: DevTools: include traces when exporting console log via 'Save as' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
index 2347ad521bfae62a6e034df302ef24ae7c486265..efbdc083220b036047f6e3621cf563c472aed8e7 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
@@ -235,6 +235,7 @@ WebInspector.DOMPresentationUtils.buildStackTracePreviewContents = function(targ
{
for (var stackFrame of stackTrace.callFrames) {
var row = createElement("tr");
+ row.createChild("td").textContent = "\n";
dgozman 2016/08/24 18:57:09 Does this change things visually? Screenshot?
luoe 2016/08/24 20:31:01 No visual change. Screenshot (normal trace on top
row.createChild("td", "function-name").textContent = WebInspector.beautifyFunctionName(stackFrame.functionName);
var link = linkifier.maybeLinkifyConsoleCallFrame(target, stackFrame);
if (link) {
@@ -257,6 +258,7 @@ WebInspector.DOMPresentationUtils.buildStackTracePreviewContents = function(targ
continue;
}
var row = contentElement.createChild("tr");
+ row.createChild("td").textContent = "\n";
row.createChild("td", "stack-preview-async-description").textContent = WebInspector.asyncStackTraceLabel(asyncStackTrace.description);
row.createChild("td");
row.createChild("td");

Powered by Google App Engine
This is Rietveld 408576698